Skip to content

Comments

feat(datafusion): Support CREATE TABLE for DataFusion#1972

Merged
liurenjie1024 merged 10 commits intoapache:mainfrom
CTTY:ctty/df-cr-tbl
Jan 14, 2026
Merged

feat(datafusion): Support CREATE TABLE for DataFusion#1972
liurenjie1024 merged 10 commits intoapache:mainfrom
CTTY:ctty/df-cr-tbl

Conversation

@CTTY
Copy link
Collaborator

@CTTY CTTY commented Dec 30, 2025

Which issue does this PR close?

What changes are included in this PR?

  • Implement register_table in IcebergSchemaProvider
  • Added a new slt: create_table.slt
  • Updated existing slts

Note: This does NOT cover the syntax CREATE TABLE ... AS VALUES

Are these changes tested?

Yes

liurenjie1024
liurenjie1024 reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CTTY for this pr, I think we also should create a tracking issue for create external table?

@CTTY
Copy link
Collaborator Author

CTTY commented Jan 12, 2026

I think we also should create a tracking issue for create external table

Yes, I think we currently have IcebergTableProviderFactory that can be used for CREATE EXTERNAL TABLE, but the problem is that it only creates a read-only static table, and we will need some bigger changes for that.

My current thought: we will need to introduce some new catalog props and pass them to IcebergTableProviderFactory and then use CatalogBuilder to load a Catalog, so we switch from using IcebergStaticTableProvider to IcebergTableProvider in IcebergTableProviderFactory.

I haven't thought quite thoroughly yet, and will create a tracking issue later, we can move the discussion there

@CTTY
Copy link
Collaborator Author

CTTY commented Jan 13, 2026

Created an issue to track create external table: #2021

liurenjie1024
liurenjie1024 approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CTTY for this fix!

@liurenjie1024 liurenjie1024 merged commit 5cf85da into apache:main Jan 14, 2026
18 checks passed
@CTTY CTTY deleted the ctty/df-cr-tbl branch January 14, 2026 00:00
@xbattlax xbattlax mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support CREATE TABLE for DataFusion

2 participants

@CTTY @liurenjie1024