Skip to content

Comments

infra: release script, validate proper ICEBERG_VERSION variable#1956

Merged
liurenjie1024 merged 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/validate-version
Dec 23, 2025
Merged

infra: release script, validate proper ICEBERG_VERSION variable#1956
liurenjie1024 merged 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/validate-version

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Dec 23, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Add a check that the input ICEBERG_VERSION variable is in the proper format, i.e. 0.8.0. Otherwise, the source directory and zip file will have the wrong name

Are these changes tested?

Added these 3 lines:

echo "Release version: $release_version"
echo "Git branch: $git_branch"
echo "Source directory: apache-iceberg-rust-$release_version"

This PR:

➜  iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=rc.1 ./scripts/release.sh  
var is set to 'rc.1'
Error: ICEBERG_VERSION (rc.1) must be in the format: <number>.<number>.<number>
➜  iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=0.8.0 ./scripts/release.sh 
var is set to '0.8.0'
Release version: 0.8.0
Git branch: release-0.8.0-rc.1
Source directory: apache-iceberg-rust-0.8.0

main:

➜  iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=rc.1 ./scripts/release.sh 
var is set to 'rc.1'
Release version: rc.1
Git branch: release-rc.1-rc.1
Source directory: apache-iceberg-rust-rc.1
➜  iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=0.8.0 ./scripts/release.sh
var is set to '0.8.0'
Release version: 0.8.0
Git branch: release-0.8.0-rc.1
Source directory: apache-iceberg-rust-0.8.0

liurenjie1024
liurenjie1024 approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for this fix!

@liurenjie1024 liurenjie1024 merged commit 152aeb6 into apache:main Dec 23, 2025
1 check passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/validate-version branch February 13, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

1 more reviewer

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinjqliu @liurenjie1024