refactor(arrow): Rename parameter in delete_filter for clarity#1955
Merged
liurenjie1024 merged 1 commit intoapache:mainfrom Dec 24, 2025
Merged
refactor(arrow): Rename parameter in delete_filter for clarity#1955liurenjie1024 merged 1 commit intoapache:mainfrom
liurenjie1024 merged 1 commit intoapache:mainfrom
Conversation
The parameter `delete_file_path` in `get_delete_vector_for_path` was misleading because the function expects a data file path, not a delete file path. Renaming it to `data_file_path` accurately reflects its usage.
liurenjie1024
approved these changes
Dec 24, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @robertmu for this fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter
delete_file_pathinget_delete_vector_for_pathwas misleading because the function expects a data file path, not a delete file path. Renaming it todata_file_pathaccurately reflects its usage.