Add case-sensitive support for equality deletes in DeleteFilter#1930
Add case-sensitive support for equality deletes in DeleteFilter#1930liurenjie1024 merged 4 commits intoapache:mainfrom
Conversation
…nsitive. This change adds optional case-sensitive matching when binding equality delete predicates. - Updated build_equality_delete_predicate to handle case-sensitive option. - Added unit tests for case-sensitive equality deletes.
slfan1989
changed the title
slfan1989
force-pushed
the
case-sensitive-equality-delete
branch
from
8fc60d3 to
e711f8b
Compare
|
@liurenjie1024 @Xuanwo Could you please help review this PR? Thank you very much! |
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @slfan1989 for this pr, generally LGTM, just one minor change.
| pub name_mapping: Option<Arc<NameMapping>>, | ||
|
|
||
| /// Whether this scan task should treat column names as case-sensitive when binding predicates. | ||
| pub case_sensitive: bool, |
There was a problem hiding this comment.
I think this should be set according TableScan?
There was a problem hiding this comment.
@liurenjie1024 Thank you very much for reviewing the code! Yes, the case_sensitive flag should indeed be set according to the TableScan. It represents a query-level property that needs to flow down through the plan context and manifest contexts into each FileScanTask, so that DeleteFilter can correctly bind equality delete predicates with the intended case-sensitivity.
The overall call chain is:
TableScan → PlanContext → ManifestFileContext → ManifestEntryContext → FileScanTask
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @slfan1989 for this fix!
@liurenjie1024 Thanks a lot for reviewing the code! |
2 participants
Which issue does this PR close?
What changes are included in this PR?
This change adds optional case-sensitive matching when binding equality delete predicates.
Are these changes tested?
Added a new unit test.