feat(arrow): Convert Arrow schema to Iceberg schema with auto assigned field ids#1928
Merged
liurenjie1024 merged 7 commits intoapache:mainfrom Dec 30, 2025
Merged
feat(arrow): Convert Arrow schema to Iceberg schema with auto assigned field ids#1928liurenjie1024 merged 7 commits intoapache:mainfrom
liurenjie1024 merged 7 commits intoapache:mainfrom
Conversation
CTTY
changed the title
| /// Builds the schema. | ||
| pub fn build(self) -> Result<Schema> { | ||
| // If field IDs need to be reassigned, do it first before validation | ||
| if let Some(start_from) = self.reassign_field_ids_from { |
Contributor
There was a problem hiding this comment.
What's the motivation of this change? The problem with this change is that it may make the error more difficult to read. For example, if user passed a non exists identifier id, originally the error message would be quite clear and easy to understand. But this change will confuse user.
Collaborator
Author
There was a problem hiding this comment.
This is a good point!
My original intention was to avoid building id-to-field map again when we are trying to reassign field ids.
liurenjie1024
approved these changes
Dec 30, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @CTTY for this pr, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
arrow_schema_to_schema_auto_assign_idsAre these changes tested?
Added uts