fix(reader): Equality delete files with partial schemas (containing only equality columns)#1782
Merged
liurenjie1024 merged 8 commits intoapache:mainfrom Nov 4, 2025
Merged
Conversation
…lity delete files. Added new test.
mbutrovich
changed the title
evolve_schema() call in load_file_for_task() for equality deletes
mbutrovich
added a commit
to mbutrovich/iceberg-rust
that referenced
this pull request
Oct 27, 2025
Contributor
|
Seems duplicated with #1778 ? |
Collaborator
Author
I mistakenly mixed changes from the two PRs, but they are independent (but related) fixes with independent tests. |
liurenjie1024
approved these changes
Nov 4, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @mbutrovich for this fix!
Contributor
|
The ci failure is unrelated, it should be fixed by #1823. I'll merge this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR close?
Partially address #1749.
Rationale for this change
Equality delete files with partial schemas (containing only equality columns) were hitting Arrow validation errors: "Column 'id' is declared as non-nullable but contains null values” in Iceberg Java’s TestSparkReaderDeletes suite. The bug occurs because
evolve_schema()adds missing columns with NULL values, which fails when those columns are declared REQUIRED in the table schema.What changes are included in this PR?
Change the
evolve_schema()call to takeequality_idsbecause per the Iceberg spec, evolve schema for equality deletes but only for theequality_idscolumns, not all table columns.Are these changes tested?
test_partial_schema_equality_deletes_evolve_succeeds