I actually suggest that we change the name. CommitFailed is a bit confusing and doesn't reflect what happened. How about CatalogCommitConflicts or something similar?

I actually suggest that we change the name. CommitFailed is a bit confusing and doesn't reflect what happened. How about CatalogCommitConflicts or something similar?

I think this is similar to java's name convention, see https://github.com/apache/iceberg/blob/6bd6887db1f90674ca5e20e88cc95c5f92dcb050/core/src/main/java/org/apache/iceberg/BaseTransaction.java#L423
But it would be better to add some doc to explain it.

I think this is similar to java's name convention, see https://github.com/apache/iceberg/blob/6bd6887db1f90674ca5e20e88cc95c5f92dcb050/core/src/main/java/org/apache/iceberg/BaseTransaction.java#L423
But it would be better to add some doc to explain it.

I agree with you that following similar Java naming conventions can benefit developers coming from Java. However, having a consistent error kind naming style makes it easier for us to maintain the list and for users to use it.

I propose the name CatalogCommitConflicts for:

• namespace: Catalog
• action: Commit
• reason: Conflicts

It's clean, self-descriptive, well-structured, and can easily scale to other possible error kinds.

By the way, I think XxxFailed is the most useless word in the world. Imagine encountering an error that simply says "CommitFailed": it doesn't convey any information at all. We can add in docs to tell jave developers that it's similiar to CommitFailedException

I think this is similar to java's name convention, see https://github.com/apache/iceberg/blob/6bd6887db1f90674ca5e20e88cc95c5f92dcb050/core/src/main/java/org/apache/iceberg/BaseTransaction.java#L423
But it would be better to add some doc to explain it.

I agree with you that following similar Java naming conventions can benefit developers coming from Java. However, having a consistent error kind naming style makes it easier for us to maintain the list and for users to use it.

I propose the name CatalogCommitConflicts for:

• namespace: Catalog
• action: Commit
• reason: Conflicts

It's clean, self-descriptive, well-structured, and can easily scale to other possible error kinds.

By the way, I think XxxFailed is the most useless word in the world. Imagine encountering an error that simply says "CommitFailed": it doesn't convey any information at all. We can add in docs to tell jave developers that it's similiar to CommitFailedException

Sounds reasonable to me.

Hi @liurenjie1024 @Xuanwo , thanks for the vaulable inputs! I've updated the error kind name based on the suggestion, please take a look again

cc @Xuanwo to take another look.