fix(metadata): export iceberg schema in snapshots table#1135
Merged
liurenjie1024 merged 5 commits intoapache:mainfrom Mar 31, 2025
Merged
fix(metadata): export iceberg schema in snapshots table#1135liurenjie1024 merged 5 commits intoapache:mainfrom
liurenjie1024 merged 5 commits intoapache:mainfrom
Conversation
same as apache#871 Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
xxchan
commented
Mar 25, 2025
Comment on lines
44
to
51
| let fields = vec![ | ||
| NestedField::required(1, "committed_at", Type::Primitive(PrimitiveType::Timestamp)), | ||
| NestedField::required(2, "snapshot_id", Type::Primitive(PrimitiveType::Long)), | ||
| NestedField::optional(3, "parent_id", Type::Primitive(PrimitiveType::Long)), | ||
| NestedField::required(4, "operation", Type::Primitive(PrimitiveType::String)), | ||
| NestedField::required(5, "manifest_list", Type::Primitive(PrimitiveType::String)), | ||
| NestedField::required( | ||
| 6, |
Member
Author
There was a problem hiding this comment.
The schema is changed to be more aligned with Java https://github.com/apache/iceberg/blob/03ff41c189c7420992be0e4a4ddc63f005e2e0d5/core/src/main/java/org/apache/iceberg/SnapshotsTable.java#L30-L40
Previously it aligns with Python.
Signed-off-by: xxchan <[email protected]>
xxchan
commented
Mar 25, 2025
Comment on lines
+45
to
+52
| arrow-arith = { version = "54.2.0" } | ||
| arrow-array = { version = "54.2.0" } | ||
| arrow-buffer = { version = "54.2.0" } | ||
| arrow-cast = { version = "54.2.0" } | ||
| arrow-ord = { version = "54.2.0" } | ||
| arrow-schema = { version = "54.2.0" } | ||
| arrow-select = { version = "54.2.0" } | ||
| arrow-string = { version = "54.2.0" } |
Member
Author
There was a problem hiding this comment.
We need to bump arrow crates, as with_keys_field is introduced in 54.2
(caught by MSRV check
Signed-off-by: xxchan <[email protected]>
liurenjie1024
approved these changes
Mar 31, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @xxchan for this pr, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as #871
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?