Open
Conversation
a9dc195 to
28dbba9
Compare
Contributor
Author
Contributor
Author
|
Potential improvement: For now, we will trave the whole record in visitor pattern, but in some case we don't need to travese child column. E.g. the map column is passthrough, we don't need type promotion for its child so we hope to return map column directly and stop traversing its child. |
fbcc13d to
8759513
Compare
17 tasks
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
SchemaWithPartnervisitor to refactorRecordBatchProjectorRecordBatchProjectorinRecordBatchTransformContext
For read or write in iceberg-rust, we interoperate with arrow RecordBatch. There are similar project tasks when reading and write to project RecordBatch:
For now, these tasks are implemented in different structs,
RecordBatchTransform, andRecordBatchProjectorand there are redundant codes. After we introduce theSchemaWithPartnervisitor in #731, we can unify the implementation under the "visitor" framework.The project task is generally separated into two parts:
We can custom accessor to achieve init-default. E.g. when fail to retrieve the array, accessor can construct the array according to init-default. And we also can custom accessor to achieve name-map.
We can customize visitors to do the type of promotion here.
The PR try this work to refactor our
RecordBatchTransform, andRecordBatchProjector. And it also complete #405 (comment) using ArrowProjectionVisitor as @liurenjie1024 mention