You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rename position delete index to clarify referenced data file key #3359
Is your feature request related to a problem or challenge?
PopulatedDeleteFileIndex::pos_deletes_by_path is keyed by the referenced data file's path. The current name leaves it unclear whether the key is the delete file's own path or the data file it applies to.
This tracks the naming follow-up requested in the #3035 review. In the September 21 review of #3145, mbutrovich explicitly asked for a separate tracking issue. The validation work in #3145 can remain separate.
Describe the solution you'd like
Rename the private field and matching local bindings from pos_deletes_by_path to pos_deletes_by_referenced_data_file in crates/iceberg/src/delete_file_index.rs, updating references and comments consistently. Preserve delete-file applicability, indexing, and scan behavior.
Validation should include the existing delete-file index tests, formatting, and Clippy. This is an internal naming cleanup with no intended public API or behavior change.
Willingness to contribute
I would be willing to contribute to this feature with guidance from the Iceberg Rust community.
Prepared with AI assistance; this issue records the requested follow-up and does not claim an implementation.
I'd like to take this one — opened #3570, which renames the private field and its local bindings to pos_deletes_by_referenced_data_file, plus the comments that mention it. One file, 14 lines, no behavior change. Thanks for tracking this in the #3145 review! (◕‿◕)
Activity
refactor(scan): rename position delete index key to referenced data file
dragonknightk commentedon Oct 28, 2026
I'd like to take this one — opened #3570, which renames the private field and its local bindings to
pos_deletes_by_referenced_data_file, plus the comments that mention it. One file, 14 lines, no behavior change. Thanks for tracking this in the #3145 review! (◕‿◕)