Conversation
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Were you able to manually run the doc server with these changes? It would be great to see if this will create anchors in the docs website.
Here's how to run the doc server
https://github.com/apache/iceberg-python/tree/main/mkdocs
|
Yes, I was able to run it locally and it worked. |
|
Thank you! Do you mind adding a screenshot of the local docs server with the anchor? |
|
Yes, sure, no problem!
|
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the contribution and the screenshot confirming the anchor.
LGTM!
|
Thanks @uatach for fixing this! I always used the menu on the right hand side to get an anchored link, which is very awkward. Thanks @kevinjqliu for the great review! |
3 participants
Fixes #808
It seems that enabling the
tocextension and itspermalinkoption should enable anchors in the section headers as per https://python-markdown.github.io/extensions/toc/#usage