Skip to content

Respect REST endpoint capabilities when checking view existence - #4337

Merged
Fokko merged 6 commits into
apache:mainfrom
ebyhr:ebi/kevinjqliu-view-exists-endpoint-fallback
Nov 11, 2026
Merged

Fokko merged 6 commits into
apache:mainfrom
ebyhr:ebi/kevinjqliu-view-exists-endpoint-fallback

Conversation

@ebyhr

@ebyhr ebyhr commented Nov 11, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Make RestCatalog.view_exists() fall back to load_view() when the server does not advertise the view HEAD endpoint, following the existing RestCatalog.table_exists() fallback and namespace existence checks. Preserve advertised HEAD behavior and existing capability defaults.

Are these changes tested?

Added separate regressions for advertised GET support, legacy servers with view support enabled, and missing views. The focused REST/view suite passes: 44 tests. Ruff, mypy, and applicable commit hooks pass.

Are there any user-facing changes?

view_exists() works with GET-capable servers that do not advertise HEAD. Missing views return False; other load errors propagate.

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice follow-up on #3960! The fallback mirrors table_exists() exactly, which keeps the two consistent.

A few observations:

  1. Duplicate fallback logic: table_exists() and view_exists() now have the same try/except-load pattern. Worth extracting a small _exists_via_load(load_fn, identifier) helper, but fine as a follow-up.

  2. Exception scope: the fallback catches NoSuchViewError, but load_view can also raise for transient failures (5xx mapped to ServiceUnavailableError). Those propagate, which is correct behavior for exists checks, just noting it is intentional.

  3. Tests cover advertised-GET, legacy-server (via view-endpoints-supported), and 404 paths. Good coverage.

Leaving as a comment review, not blocking.

@Fokko
Fokko added this pull request to the merge queue Nov 11, 2026
Merged via the queue into apache:main with commit a60c7cc Nov 11, 2026
20 checks passed
@ebyhr
ebyhr deleted the ebi/kevinjqliu-view-exists-endpoint-fallback branch November 12, 2026 00:10
krishan711 added a commit to krishan711/iceberg-python that referenced this pull request Nov 12, 2026
…of-structs

* upstream/main: (78 commits)
  fix(io): keep null lists of structs when projecting Arrow data (apache#4065)
  Skip unknown nested fields when resolving Avro read schemas (apache#4289)
  fix(expressions): reject non-finite floats on conversion to Decimal (apache#4287)
  fix: handle negative-scale Decimals in increment, decrement and truncate_decimal (apache#4285)
  Match NaN partition values with `IsNaN` in partition predicates (apache#4281)
  Fix append when a data column is named like a partition helper column (apache#4344)
  Widen decimal literal precision in scan filters (apache#4348)
  Add row-lineage support with Spark tests (apache#3972)
  Serialize purgeRequested as a lowercase boolean in REST drop_table (apache#4341)
  Validate each branch against its own commits on retry (apache#4317)
  Core: Compare upsert rows column by column instead of cell by cell (apache#4334)
  Core: Write added files under the partition spec they were planned with (apache#4338)
  Core: Check whether a failed last commit attempt landed before cleanup (apache#4339)
  REST: Use the standard User-Agent format (apache#4330)
  SQL: Accept an existing SQLAlchemy engine in SqlCatalog (apache#4336)
  Expose catalog labels on Table (apache#4321)
  Respect REST endpoint capabilities when checking view existence (apache#4337)
  Reject existing ref names in create_branch and create_tag (apache#4319)
  Assert every ref a transaction writes, not just the first (apache#4315)
  feat: send Idempotency-Key on REST mutations when the server advertises it (apache#4310)
  ...

# Conflicts:
#	pyiceberg/io/pyarrow.py
#	tests/io/test_pyarrow.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants