Repository navigation
Prune dependency upper bounds - #3586
Conversation
Update the lockfile after relaxing removable dependency caps and refresh tests for newer Moto and PyArrow behavior.
…e-pyproject-upper-bounds # Conflicts: # tests/io/test_pyarrow.py # uv.lock
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
I don't think the upper bounds serve any purpose. I think this is a relic from the good ol' requirements.txt so I'm fine with removing them. Did you regenerate the uv.lock with the latest versions?
| _original_table_init = FakeTable.__init__ | ||
|
|
||
| def _table_init_with_location(self, database_name, table_name, table_input, catalog_id): # type: ignore | ||
| def _table_init_with_location(self, database_name, table_name, table_input, *args, **kwargs): # type: ignore |
There was a problem hiding this comment.
Not against these changes, but I think they are unrelated?
There was a problem hiding this comment.
this is because updated moto included a new open_table_format_input param
https://github.com/getmoto/moto/blame/09a8275d8330e359b0b35f5325e7740ed26552b7/moto/glue/models.py#L1715
passing args/kwargs through
yep! i did, to prove that all the dependencies are still working properly :) |
This PR removes as many upperbounds restrictions as possible from our dependencies.
Why remove unnecessary upper bounds:
We already removed upperbound for pyarrow in #2258
And theres a request to remove upperbound for cachetools in #3214
Closes #3214
Changes:
uv.lockwith upgraded packages.Validation:
make test PYTHON=3.12(3736 passed, 1534 deselected)