Merged
Conversation
Contributor
Fokko
commented
Dec 4, 2023
Fokko
commented
Fokko
force-pushed
the
fd-iceberg-python
branch
from
dba6ec8 to
63b3f24
Compare
Fokko
force-pushed
the
fd-iceberg-python
branch
from
fa55407 to
ae31c4f
Compare
Fokko
force-pushed
the
fd-iceberg-python
branch
from
ae31c4f to
d0102fd
Compare
Contributor
|
You might be able to support arbitrary SQL-like catalogs using https://github.com/ibis-project/ibis |
Contributor
Author
|
@jayceslesar Thanks for chiming in here! If I'm not mistaken, PyIceberg could serve as a backend behind the Ibis front end. We currently use sqlalchemy as an ORM for different database implementations. |
bitsondatadev
approved these changes
Dec 5, 2023
Contributor
bitsondatadev
left a comment
bitsondatadev
left a comment
There was a problem hiding this comment.
Few nits in the docs, but LGTM!
|
|
||
| import pytest | ||
| from pytest import TempPathFactory | ||
| from pytest_lazyfixture import lazy_fixture |
Co-authored-by: Brian "bits" Olsen <[email protected]>
Co-authored-by: Brian "bits" Olsen <[email protected]>
…nto fd-iceberg-python
Contributor
Author
|
Thanks for the suggestions @bitsondatadev 🙌 |
HonahX
approved these changes
Dec 8, 2023
rdblue
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.