Merged
Conversation
kevinjqliu
approved these changes
May 28, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
Similar fix in pyiceberg's CI apache/iceberg-python#2049
This was referenced Jun 6, 2025
liurenjie1024
pushed a commit
to apache/iceberg-rust
that referenced
this pull request
Jun 7, 2025
## Which issue does this PR close? - Closes #. ## What changes are included in this PR? `mc config` is deprecated minio/mc#5206 Similar to fix in iceberg-python and iceberg-go apache/iceberg-python#2049 apache/iceberg-go#444 This PR also updates the image version of `minio:minio` and `minio:mc` to the latest available tag to pull in the change where `mc config` is deprecated. ## Are these changes tested?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taken from apache/iceberg-python#2049
Looks like
mc configis deprecated minio/mc#5206