Repository navigation
feat(catalog/rest): use the REST spec User-Agent format - #2516
Merged
Merged
Conversation
Send iceberg-go/<version> (go <go version>) as the default User-Agent, following the format recommended by the REST catalog spec (apache/iceberg#17727). Headers configured by the caller still take precedence over the default.
laskoviymishka
approved these changes
Nov 11, 2026
laskoviymishka
left a comment
laskoviymishka
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rahulsmahadev for picking this up right after apache/iceberg#17727 landed. The new value follows the spec's product/version (runtime version) shape with the iceberg-go token the spec lists, and TestDefaultUserAgent covers both the v strip and the unknown fallback.
Contributor
|
@rahulsmahadev welcome to contributors club! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Iceberg REST catalog spec now recommends a standard User-Agent format (apache/iceberg#17727). iceberg-go now sends
iceberg-go/<version> (go <go version>), for exampleiceberg-go/0.4.0 (go 1.27.1), instead ofGoIceberg/<version>.vof the module version is dropped, so all Iceberg clients send plain versions.unknownas the version.Testing:
TestDefaultUserAgent, plus the existing header tests updated for the new value.This pull request and its description were written by Isaac.