AWS: Use Apache HTTP client as default AWS HTTP client#7119
Merged
jackye1995 merged 3 commits intoapache:masterfrom Mar 16, 2023
Merged
AWS: Use Apache HTTP client as default AWS HTTP client#7119jackye1995 merged 3 commits intoapache:masterfrom
jackye1995 merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
Does integration tests still pass? |
jackye1995
reviewed
Mar 15, 2023
singhpk234
force-pushed
the
enhancement/http-client
branch
from
5bc86e4 to
9f2f06b
Compare
JonasJ-ap
reviewed
Mar 16, 2023
singhpk234
force-pushed
the
enhancement/http-client
branch
2 times, most recently
from
10f361f to
83a3514
Compare
singhpk234
force-pushed
the
enhancement/http-client
branch
from
83a3514 to
c79c1e3
Compare
jackye1995
approved these changes
Mar 16, 2023
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
We probably want to overall refactor a bit of the AWS doc, but that can be done in another PR, this looks good to me.
Also in the next release including this, we need to mention the dependency change in release note, in case people just include the minimum number of AWS jars and only have dependency of url-connection-client.
Contributor
|
@nastra @danielcweeks could you check if you have any concern of updating this default dependency? |
danielcweeks
approved these changes
Mar 16, 2023
nastra
approved these changes
Mar 16, 2023
bryanck
approved these changes
Mar 16, 2023
Fokko
approved these changes
Mar 16, 2023
Contributor
|
Thanks everyone for the review! And thanks @singhpk234 for the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7118