Skip to content

chore: several fixes on the LICENSE/NOTICE - #15449

Merged
RussellSpitzer merged 13 commits into
apache:mainfrom
jbonofre:license-polish
Mar 12, 2026
Merged

chore: several fixes on the LICENSE/NOTICE#15449
RussellSpitzer merged 13 commits into
apache:mainfrom
jbonofre:license-polish

Conversation

@jbonofre

@jbonofre jbonofre commented Feb 26, 2026

Copy link
Copy Markdown
Member
  • Important fixes
    • include BSD/MIT license content inline in all LICENSE files
    • update copyright year to 2026
    • select a single license (when dual) in all LICENSE files
    • remove dependency versions to relax the updates (dependabot)
  • Minor fixes
    • Use the "This product bundles"/"This product includes code" wording everywhere
    • Use the same AL v2 license wording everywhere

@jbonofre
Several fixes on the LICENSE/NOTICE:
38d9a49 
* Important fixes
** include BSD/MIT license content inline in all LICENSE files
** update copyright year to 2026
** select a single license (when dual) in all LICENSE files
** remove dependency versions to relax the updates (dependabot)
* Minor fixes
** Use the "This product bundles"/"This product includes code" wording everywhere
** Use the same AL v2 license wording everywhere
@jbonofre jbonofre changed the title Several fixes on the LICENSE/NOTICE: chore: several fixes on the LICENSE/NOTICE Feb 26, 2026
@jbonofre

jbonofre commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

I'm also doing a full pass on the dependencies use.

@jbonofre
jbonofre requested a review from manuzhang February 26, 2026 09:46
@jbonofre

jbonofre commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

@manuzhang I saw several missing dependencies missing in LICENSEs (flink-runtime, ...).

I'm doing a full pass.

It seems the GCP (BigQuery, ...) support added several dependencies but the LICENSE files have not been updated.

@manuzhang

manuzhang commented Feb 27, 2026

Copy link
Copy Markdown
Member

Is there a tool that can check whether license info of dependencies is missing?

@jbonofre

jbonofre commented Feb 27, 2026

Copy link
Copy Markdown
Member Author

@manuzhang I have scripts (using jar tvf/find to find what's bundled, etc). For this PR, I'm doing also manual checks/updated

This was referenced Mar 2, 2026
Open
Merged
RussellSpitzer added a commit to RussellSpitzer/iceberg that referenced this pull request Mar 2, 2026
@RussellSpitzer
Fix license accuracy issues found during review of PR apache#15449
47edca1 
- Reactive Streams: correct license label from MIT to MIT-0
  (MIT No Attribution is a distinct SPDX identifier)
- Findbugs jsr305: correct license from Apache 2.0 to BSD 3-Clause
  with inline text (per the project's own LICENSE file)
- Google API Common/GAX/Auth Library: use BSD 3-Clause consistently
  in kafka-connect bundles to match gcp-bundle and actual repo LICENSE files
- Jackson: update dead codehaus.org URL to github.com/FasterXML/jackson
- Fix typos: "bt" -> "by", "prodduct" -> "product", "produt" -> "product"
- Remove empty section artifact in azure-bundle LICENSE
- Remove duplicate Animal Sniffer Annotations line in flink LICENSE files

Made-with: Cursor
@RussellSpitzer RussellSpitzer mentioned this pull request Mar 2, 2026
Open
RussellSpitzer
RussellSpitzer reviewed Mar 2, 2026
View reviewed changes

@RussellSpitzer RussellSpitzer left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed review comments have been moved to the fix PR: jbonofre#1 (comment)

@RussellSpitzer

RussellSpitzer commented Mar 2, 2026

Copy link
Copy Markdown
Member

Had Cursor go through and take a look for any discrepancies, they are in the PR above^

@jbonofre

jbonofre commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

I just updated the PR to have all fixes there.

@jbonofre

jbonofre commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

@RussellSpitzer @manuzhang I completed the full pass and fixes on all LICENSE and NOTICE.

@jbonofre jbonofre mentioned this pull request Mar 3, 2026
Closed
manuzhang
manuzhang reviewed Mar 4, 2026
View reviewed changes
Comment thread aws-bundle/LICENSE Resolved
manuzhang
manuzhang reviewed Mar 4, 2026
View reviewed changes
Comment thread flink/v1.20/flink-runtime/LICENSE Resolved
manuzhang
manuzhang reviewed Mar 4, 2026
View reviewed changes
Comment thread flink/v1.20/flink-runtime/NOTICE Resolved
manuzhang
manuzhang reviewed Mar 4, 2026
View reviewed changes
Comment thread gcp-bundle/NOTICE Resolved
manuzhang
manuzhang reviewed Mar 4, 2026
View reviewed changes
Comment thread kafka-connect/kafka-connect-runtime/hive/LICENSE
License (from POM): The Apache Software License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt

--------------------------------------------------------------------------------
This product bundles Android Annotations.

@manuzhang manuzhang Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency looks strange to me.

@jbonofre jbonofre Mar 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the kafka-connect runtime distribution (zip file), you can find lib/annotations-4.1.1.4.jar corresponding to this artifact: https://repo1.maven.org/maven2/com/google/android/annotations/4.1.1.4/
That's the reason why we have to "document" it in the LICENSE file.

manuzhang
manuzhang reviewed Mar 4, 2026
View reviewed changes
Comment thread kafka-connect/kafka-connect-runtime/main/NOTICE Resolved
RussellSpitzer
RussellSpitzer reviewed Mar 4, 2026
View reviewed changes
Comment thread aws-bundle/LICENSE
Group: org.reactivestreams Name: reactive-streams Version: 1.0.4
Project URL: http://reactive-streams.org
License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/
License: MIT

@RussellSpitzer RussellSpitzer Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this to be MIT-0 ?

@RussellSpitzer RussellSpitzer Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got flagged in azure-bundle, kafka-connect/main and kafka-connect/hive

@jbonofre jbonofre Mar 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/reactive-streams/reactive-streams-jvm it's a MIT licenses, but https://github.com/reactive-streams/reactive-streams-io/blob/master/LICENSE is for reactive streams IO.

We are using reactive steams JVM according to the packaged artifacts/classes.

@RussellSpitzer RussellSpitzer Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that line 245 states this is MIT-0 and not MIT

So either we have the copyright text wrong below or we have the SPDX wrong

RussellSpitzer
RussellSpitzer reviewed Mar 4, 2026
View reviewed changes
Comment thread flink/v1.20/flink-runtime/LICENSE Resolved
RussellSpitzer
RussellSpitzer reviewed Mar 4, 2026
View reviewed changes
Comment thread spark/v3.4/spark-runtime/LICENSE

This product bundles Google GAX.

--------------------------------------------------------------------------------

@RussellSpitzer RussellSpitzer Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This separator belongs on line 678 (Same issue in other spark bundles)

RussellSpitzer
RussellSpitzer reviewed Mar 4, 2026
View reviewed changes
Comment thread flink/v2.0/flink-runtime/LICENSE Resolved
RussellSpitzer
RussellSpitzer reviewed Mar 4, 2026
View reviewed changes
Comment thread flink/v2.0/flink-runtime/LICENSE Resolved
@RussellSpitzer

RussellSpitzer commented Mar 4, 2026

Copy link
Copy Markdown
Member

Not sure if it matters but all the jackson links still point to codehaus which is a dead link now

@jbonofre

jbonofre commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

@manuzhang @RussellSpitzer I addressed your comments. Thanks !

@manuzhang manuzhang added this to the Iceberg 1.11.0 milestone Mar 9, 2026
@manuzhang
manuzhang requested a review from RussellSpitzer March 9, 2026 23:53
@RussellSpitzer
RussellSpitzer merged commit fb2c8ac into apache:main Mar 12, 2026
5 checks passed
@RussellSpitzer

RussellSpitzer commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks @jbonofre ! Also thanks @manuzhang for reviewing

@kevinjqliu kevinjqliu mentioned this pull request Mar 30, 2026
Merged
@manuzhang manuzhang mentioned this pull request Apr 1, 2026
Merged
talatuyarer pushed a commit to talatuyarer/iceberg that referenced this pull request Apr 1, 2026
@jbonofre @talatuyarer
chore: several fixes on the LICENSE/NOTICE (apache#15449)
51607c6
@manuzhang manuzhang mentioned this pull request Apr 2, 2026
Closed
@rdblue rdblue mentioned this pull request Apr 23, 2026
Merged
@kevinjqliu kevinjqliu mentioned this pull request Apr 30, 2026
Merged
@kevinjqliu kevinjqliu mentioned this pull request Oct 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuzhang manuzhang manuzhang approved these changes
@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer

Assignees

No one assigned

Labels

AWS AZURE flink GCP KAFKACONNECT OPENAPI spark

Projects

None yet

Milestone

Iceberg 1.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jbonofre @manuzhang @RussellSpitzer