Build: Exclude roaringbitmap dependency from Spark and update LICENSE files#15405
Conversation
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
Changes are similar to the original PR to update roaringbitmap, #14991
Could you include the reason to exclude the group in spark in the PR description?
There was a problem hiding this comment.
Pull request overview
This PR addresses dependency conflicts between Apache Iceberg's direct usage of RoaringBitmap and Spark's transitive dependency on it. The PR bumps RoaringBitmap from version 1.3.0 to 1.6.10 (as part of PR #15404) and prevents version conflicts by excluding the roaringbitmap dependency from Spark's spark-hive transitive dependencies.
Changes:
- Added roaringbitmap exclusion from spark-hive dependency in integrationImplementation configurations across all Spark versions (3.4, 3.5, 4.0, 4.1)
- Updated LICENSE files in open-api and kafka-connect modules to reflect RoaringBitmap version 1.6.10
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spark/v3.4/build.gradle | Added roaringbitmap exclusion from spark-hive in integrationImplementation configuration |
| spark/v3.5/build.gradle | Added roaringbitmap exclusion from spark-hive in integrationImplementation configuration |
| spark/v4.0/build.gradle | Added roaringbitmap exclusion from spark-hive in integrationImplementation configuration |
| spark/v4.1/build.gradle | Added roaringbitmap exclusion from spark-hive in integrationImplementation configuration |
| open-api/LICENSE | Updated RoaringBitmap version from 1.3.0 to 1.6.10 |
| kafka-connect/kafka-connect-runtime/main/LICENSE | Updated RoaringBitmap version from 1.3.0 to 1.6.10 |
| kafka-connect/kafka-connect-runtime/hive/LICENSE | Updated RoaringBitmap version from 1.3.0 to 1.6.10 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
since #15404 is already merged, lets get this in too |
Closes #15370 as a follow-up of #15404
This PR prevents version conflicts by excluding roaringbitmap from Spark's transitive dependencies in integration tests. LICENSE files are also updated to reflect RoaringBitmap version 1.6.10