Skip to content

Row-level-deletes in spec is not rendered as bulleted list - #13816

Closed
guixiaowen wants to merge 2 commits into
apache:mainfrom
guixiaowen:doc_of_row_level_deletes
Closed

guixiaowen wants to merge 2 commits into
apache:mainfrom
guixiaowen:doc_of_row_level_deletes

Conversation

@guixiaowen

Copy link
Copy Markdown
Contributor

Issues
#13813

Row-level-deletes in spec is not rendered as bulleted list

@github-actions github-actions Bot added the Specification Issues that may introduce spec changes. label Aug 14, 2025
Comment thread format/spec.md
There are two types of row-level deletes:
* _Position deletes_ mark a row deleted by data file path and the row position in the data file. Position deletes are encoded in a [_position delete file_](#position-delete-files) (V2) or [_deletion vector_](#deletion-vectors) (V3 or above).
* _Equality deletes_ mark a row deleted by one or more column values, like `id = 5`. Equality deletes are encoded in [_equality delete file_](#equality-delete-files).
* **Position deletes** -- Mark a row deleted by data file path and the row position in the data file. Position deletes are encoded in a [_position delete file_](#position-delete-files) (V2) or [_deletion vector_](#deletion-vectors) (V3 or above).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's really just missing a newline after L105 to properly be rendered as a bulleted list item. You can deploy the site locally and then check if it's fixed as described in https://github.com/apache/iceberg/blob/a8d111eaa7bfb3f98a236578cee3b2ff14b7b338/site/README.md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will check it soon

@RussellSpitzer

Copy link
Copy Markdown
Member

As a note, please build the docs and give a snapshot of the new rendering when doing doc changes like this. This way we can see immediately the change. Thanks @nastra for pointing towards those docs

@guixiaowen

Copy link
Copy Markdown
Contributor Author

As a note, please build the docs and give a snapshot of the new rendering when doing doc changes like this. This way we can see immediately the change. Thanks @nastra for pointing towards those docs

Ok, I will check it soon. Thank you.

@RussellSpitzer

Copy link
Copy Markdown
Member

@guixiaowen Are you going to finish this up? If not we have another community member who is looking to fix this issue

@guixiaowen

Copy link
Copy Markdown
Contributor Author

@guixiaowen Are you going to finish this up? If not we have another community member who is looking to fix this issue

@RussellSpitzer OK.

@guixiaowen guixiaowen closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Specification Issues that may introduce spec changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants