Flink 1.19, 1.20: Remove the MiniClusterWithClientResource dependency - #13165

@nastra

Hello !

I noticed that spotlessApply is not supported for iceberg-flink:iceberg-flink-1.19 or iceberg-flink:iceberg-flink-1.20, so I proceeded using iceberg-flink:iceberg-flink-2.0:spotlessApply, and it seemed to work without issues locally.

However, when running the CI, a spotlessApply issue occurs.
Is there another command or approach I can use to align the formatting with what CI expects?

You can run ./gradlew -DallModules spotlessApply but you need to enable the Flink version(s) locally in gradle.properties so that they are added as project modules

You can run ./gradlew -DallModules spotlessApply but you need to enable the Flink version(s) locally in gradle.properties so that they are added as project modules

@nastra
Thank you for your feedback.
As you suggested, I’ll try building with Gradle again and submit a new pull request.

It seems that the previous commits were included because I reused the same fork.
So, I’ll fork the repository again and create a new pull request with a clean history.

Thank you again.

@nastra

Hello,

I’ve completed the backport.
Please review and merge it when you get a chance!

Also, this is a separate topic —
After my previous PR was merged, I was expecting to see my name listed on the contributors page, but it hasn’t shown up yet.

Is merging into main not enough for that?
Is there anything else I need to do to be listed?

I’m looking forward to continuing to contribute to the Iceberg community and actively helping resolve issues!

Thanks always 🙇

Merged to main.
Thanks @JeonDaehong for the backport and @nastra for the review.

After my previous PR was merged, I was expecting to see my name listed on the contributors page, but it hasn’t shown up yet.

Is merging into main not enough for that?
Is there anything else I need to do to be listed?

I see people with 7-8 commits on the list. Maybe that's the threshold?

I’m looking forward to continuing to contribute to the Iceberg community and actively helping resolve issues!

We are looking forward your contributions!
Welcome to the team! 😄

Merged to main. Thanks @JeonDaehong for the backport and @nastra for the review.

After my previous PR was merged, I was expecting to see my name listed on the contributors page, but it hasn’t shown up yet.
Is merging into main not enough for that?
Is there anything else I need to do to be listed?

I see people with 7-8 commits on the list. Maybe that's the threshold?

I’m looking forward to continuing to contribute to the Iceberg community and actively helping resolve issues!

We are looking forward your contributions! Welcome to the team! 😄

Thank you for merging!
I’ll continue to do my best and stay active!

Merged to main. Thanks @JeonDaehong for the backport and @nastra for the review.

After my previous PR was merged, I was expecting to see my name listed on the contributors page, but it hasn’t shown up yet.
Is merging into main not enough for that?
Is there anything else I need to do to be listed?

I see people with 7-8 commits on the list. Maybe that's the threshold?

I’m looking forward to continuing to contribute to the Iceberg community and actively helping resolve issues!

We are looking forward your contributions! Welcome to the team! 😄

Hello !

Upon checking, I realized that there was a typo in the user.name and user.email fields in my global Git config on my local machine.
(It seems that this might prevent my contributions from appearing correctly in the contributors list.)

Unfortunately, the changes have already been merged, so I assume it’s too late to fix this now.
If there’s any way to correct it retrospectively, I’d really appreciate your guidance.

Otherwise, I’ll make sure to set the correct user.name and user.email in my Git config before submitting future PRs.

@JeonDaehong Thank you very much for your contribution! I’ve had a similar experience, so here’s a little tip to ease your worries.
The contributors page seems to be somewhat of a sample (just a guess), and at first, I couldn’t find myself there either. If you keep contributing more, your name will show up.

You can also find your contributions here: https://github.com/apache/iceberg/commits/main/?author=JeonDaehong.
Of course, it’s still important to have your Git config set correctly.

Hope you keep up the great work, and welcome to the team!

@JeonDaehong Thank you very much for your contribution! I’ve had a similar experience, so here’s a little tip to ease your worries.
The contributors page seems to be somewhat of a sample (just a guess), and at first, I couldn’t find myself there either. If you keep contributing more, your name will show up.

You can also find your contributions here: https://github.com/apache/iceberg/commits/main/?author=JeonDaehong.
Of course, it’s still important to have your Git config set correctly.

Hope you keep up the great work, and welcome to the team!

Thank you so much for checking and for sharing your experience — I really appreciate it!

I'm excited to contribute more as a member of the Iceberg community.
I'll also do my best to communicate actively, so I'm looking forward to working with you all :D