Merged
Conversation
nastra
reviewed
Jan 21, 2025
api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java
Outdated
Show resolved
Hide resolved
HonahX
reviewed
Jan 22, 2025
3 tasks
HonahX
reviewed
Jan 22, 2025
RussellSpitzer
approved these changes
Jan 23, 2025
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
I'm ok allowing Unknown in all these transforms and such, but I don't think we actually have a case where it can happen.
nastra
approved these changes
Jan 24, 2025
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM with one minor comment around testing
Contributor
Author
|
Thanks @HonahX @RussellSpitzer and @nastra for the review 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11732