[AWS] S3FileIO - Add Cross-Region Bucket Access#11259
Conversation
1072af2 to
5dfd7f4
Compare
singhpk234
left a comment
There was a problem hiding this comment.
Looks good to me ! would request to mark original author of PR as co-author in the pr description
cc @flyrain @RussellSpitzer
you might also wanna take a look as because of this one had to create PolarisS3FileIOClientFactory
flyrain
left a comment
There was a problem hiding this comment.
LGTM. Wondering if the aws client can allow missing the client.region config now. cc @jackye1995
|
Thank you @singhpk234 @flyrain for the review. I would wait at least for couple of days for @ebelgasmi12 to respond. Maybe, we can cherry pick commits and add it to original PR, so that original PR can be merged |
|
@flyrain @singhpk234 @jackye1995 @RussellSpitzer |
@flyrain what do you mean by this? I think that config has been optional? And it will try to resolve the region using the default region chain https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/region-selection.html#automatically-determine-the-aws-region-from-the-environment |
|
@jackye1995, I meant the |
|
Thanks @munendrasn for the PR. Thanks all for the review. |
No I don't think it is mandatory, I never set this in my sessions at least. If you find it otherwise, we should probably fix it. |
|
Thanks @ebelgasmi12 for the original changes, Thank you all for the review |
This PR is on top of the changes in PR #9804 from @ebelgasmi12 .
Additionally, The PR contains integration test for cross region changes.
cc @elmehdibelgasmi @singhpk234