Conversation
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Overall LGTM, just had a comment on clarifying the code comment a bit more.
It'd be ideal to be able to not have to rely on timing but I also want to unblock flaky tests that others may be hitting on the PR and since this is a test we can always change it later if we are able to get a better way of testing what we want to test.
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java
Outdated
Show resolved
Hide resolved
29d7f3a to
e9d86fc
Compare
Yes I agree, we don't want to rely on the timing of the test class itself and typically running this test locally took < 10 seconds so I initially just picked 100 seconds for the token expiration, which on the other hand didn't seem enough for CI. |
fixes #10599