OpenAPI: Clarify in REST spec that server implementations of commit endpoints must fail with 400 for unknown requirements/updates#10848
Merged
amogh-jahagirdar merged 1 commit intoapache:mainfrom Aug 16, 2024
Conversation
…oints must fail with 400 if any unknown updates or requirements are received
Contributor
Author
|
I will start a mailing list thread on this as well |
amogh-jahagirdar
requested review from
RussellSpitzer,
ajantha-bhat,
jackye1995,
jbonofre,
nastra,
rdblue and
szehon-ho
Contributor
Author
|
cc @emkornfield |
amogh-jahagirdar
changed the title
nastra
approved these changes
Aug 2, 2024
Fokko
approved these changes
Aug 2, 2024
Contributor
|
Small nit on title, s/should/must/ |
emkornfield
approved these changes
Aug 2, 2024
amogh-jahagirdar
changed the title
findepi
approved these changes
Aug 2, 2024
advancedxy
approved these changes
Aug 6, 2024
flyrain
approved these changes
Aug 8, 2024
dramaticlly
approved these changes
Aug 13, 2024
Contributor
Author
|
Thanks everyone for reviewing, the vote has passed https://lists.apache.org/thread/99lo7stnprchjzosjcq9k3mns1mq8fwc |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
…oints must fail with 400 if any unknown updates or requirements are received (apache#10848)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change clarifies in the REST Spec that server implementations for commit endpoints should fail with 400
for any unknown requirements/updates. This ensures that server implementations should not ignore table change or requirement to ensure correctness guarantees for implementations.
The default implementation already fails for unknown updates and requirements.