Core: Refactor ZOrderByteUtils#10624
Conversation
|
ping: @nastra |
|
I think this is generally fine, but I do think the internal methods being called should probably be renamed rather that continuing to use the "long" and "double" method names. for example having a and "floatingPointOrderedBytes" |
|
@RussellSpitzer: Thanks for the review. I have extracted the inner method as you suggested. |
|
Failed due to flaky test: #10599 |
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Sorry, I missed that the java docs all need to be fixed now. They now reference things which aren't happening anymore. The implementation details should go in the doc for wholeNumberedOrderedBytes and FloatingPOintOrderedBytes
|
@RussellSpitzer: I have updated it today. Sorry for delay on this. I lost track of this PR notification. |
|
Thanks @ajantha-bhat , Merged |
* main: (208 commits) Docs: Fix Flink 1.20 support versions (apache#11065) Flink: Fix compile warning (apache#11072) Docs: Initial committer guidelines and requirements for merging (apache#10780) Core: Refactor ZOrderByteUtils (apache#10624) API: implement types timestamp_ns and timestamptz_ns (apache#9008) Build: Bump com.google.errorprone:error_prone_annotations (apache#11055) Build: Bump mkdocs-material from 9.5.33 to 9.5.34 (apache#11062) Flink: Backport PR apache#10526 to v1.18 and v1.20 (apache#11018) Kafka Connect: Disable publish tasks in runtime project (apache#11032) Flink: add unit tests for range distribution on bucket partition column (apache#11033) Spark 3.5: Use FileGenerationUtil in PlanningBenchmark (apache#11027) Core: Add benchmark for appending files (apache#11029) Build: Ignore benchmark output folders across all modules (apache#11030) Spec: Add RemovePartitionSpecsUpdate REST update type (apache#10846) Docs: bump latest version to 1.6.1 (apache#11036) OpenAPI, Build: Apply spotless to testFixtures source code (apache#11024) Core: Generate realistic bounds in benchmarks (apache#11022) Add REST Compatibility Kit (apache#10908) Flink: backport PR apache#10832 of inferring parallelism in FLIP-27 source (apache#11009) Docs: Add Druid docs url to sidebar (apache#10997) ...
2 participants
Follow up from #10583 (comment)
Addressing my own comment.
intToOrderedBytesto uselongToOrderedBytesas it is the same code.longToOrderedBytesforshortToOrderedBytesandtinyintToOrderedBytesto avoid double casting.