Skip to content

feat(client): support edgeExistence api#544

Merged
coderzc merged 21 commits intoapache:masterfrom
msgui:support-edgeexistence-api
Dec 12, 2023
Merged

feat(client): support edgeExistence api#544
coderzc merged 21 commits intoapache:masterfrom
msgui:support-edgeexistence-api

Conversation

@msgui
Copy link
Copy Markdown
Contributor

@msgui msgui commented Nov 30, 2023

Purpose of the PR

Main Changes

  • support edgeexistence api

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@github-actions github-actions bot added the client hugegraph-client label Nov 30, 2023
@msgui
Copy link
Copy Markdown
Contributor Author

msgui commented Nov 30, 2023 •
edited
Loading

I've run into a challenging error, seemingly caused by errors related to the 'COMMIT_ID', resulting in GitHub CI not running smoothly.
fatal: reference is not a tree: be6ee386b9939dc6bd6fcbdf2274b8acc3a0a314

image

@imbajin
Copy link
Copy Markdown
Member

imbajin commented Nov 30, 2023

I've run into a challenging error, seemingly caused by errors related to the 'COMMIT_ID', resulting in GitHub CI not running smoothly. fatal: reference is not a tree: be6ee386b9939dc6bd6fcbdf2274b8acc3a0a314

image

refer #542 (comment)

javeme
javeme reviewed Dec 3, 2023
View reviewed changes
@github-actions github-actions bot added hubble hugegraph-hubble loader hugegraph-loader tools hugegraph-tools labels Dec 4, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (b066b80) 62.49% compared to head (a639a1b) 62.55%.
Report is 8 commits behind head on master.

Files Patch % Lines
.../apache/hugegraph/structure/traverser/VESteps.java 53.48% 20 Missing ⚠️
...ugegraph/structure/traverser/KneighborRequest.java 66.66% 4 Missing ⚠️
...che/hugegraph/structure/traverser/KoutRequest.java 69.23% 4 Missing ⚠️
.../org/apache/hugegraph/driver/TraverserManager.java 25.00% 3 Missing ⚠️
...ache/hugegraph/structure/traverser/ApiMeasure.java 25.00% 3 Missing ⚠️
...g/apache/hugegraph/structure/traverser/VEStep.java 80.00% 3 Missing ⚠️
...n/java/org/apache/hugegraph/driver/HugeClient.java 33.33% 2 Missing ⚠️
...egraph/structure/traverser/CrosspointsRequest.java 60.00% 2 Missing ⚠️
...aph/structure/traverser/CustomizedCrosspoints.java 0.00% 2 Missing ⚠️
...gegraph/structure/traverser/JaccardSimilarity.java 66.66% 2 Missing ⚠️
... and 17 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #544      +/-   ##
============================================
+ Coverage     62.49%   62.55%   +0.05%     
- Complexity     1903     1923      +20     
============================================
  Files           262      267       +5     
  Lines          9541     9677     +136     
  Branches        886      888       +2     
============================================
+ Hits           5963     6053      +90     
- Misses         3190     3235      +45     
- Partials        388      389       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msgui msgui mentioned this pull request Dec 7, 2023
Merged
10 tasks
@msgui
Copy link
Copy Markdown
Contributor Author

msgui commented Dec 7, 2023 •
edited
Loading

apache/hugegraph#2380 After merging, continue.

@msgui msgui force-pushed the support-edgeexistence-api branch from 4d941b1 to 72df58c Compare December 9, 2023 08:56
@github-actions github-actions bot removed hubble hugegraph-hubble loader hugegraph-loader tools hugegraph-tools labels Dec 9, 2023
@imbajin imbajin changed the title feat: support edgeexistence api feat(client): support edgeExistence api Dec 9, 2023
@github-actions github-actions bot added hubble hugegraph-hubble loader hugegraph-loader tools hugegraph-tools labels Dec 9, 2023
@msgui msgui requested a review from javeme December 9, 2023 11:25
@imbajin
Copy link
Copy Markdown
Member

imbajin commented Dec 11, 2023

merge after #550

@github-actions github-actions bot removed hubble hugegraph-hubble loader hugegraph-loader tools hugegraph-tools labels Dec 12, 2023
@coderzc coderzc merged commit b7095aa into apache:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imbajin imbajin imbajin approved these changes

@coderzc coderzc coderzc approved these changes

@javeme javeme Awaiting requested review from javeme

Assignees

No one assigned

Labels

client hugegraph-client

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msgui @imbajin @javeme @coderzc