Skip to content

fix(client): server api version mismatch#542

Closed
liuxiaocs7 wants to merge 11 commits intoapache:masterfrom
liuxiaocs7:fix_version_match
Closed

fix(client): server api version mismatch#542
liuxiaocs7 wants to merge 11 commits intoapache:masterfrom
liuxiaocs7:fix_version_match

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 commented Nov 30, 2023

Purpose of the PR

hugegraph/hugegraph-test#5 (comment)

api version is outdated in client will be handled in #546, this pr will handle the ci problem later~

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin
Copy link
Copy Markdown
Member

imbajin commented Nov 30, 2023

�thanks, could also update the commit in this PR
image

maybe could choose ed493f3093eab293a75cd2f539e29ca11fa6cd81 (apache/hugegraph@ed493f3)

@liuxiaocs7
Copy link
Copy Markdown
Member Author

liuxiaocs7 commented Nov 30, 2023

�thanks, could also update the commit in this PR image

maybe could choose ed493f3093eab293a75cd2f539e29ca11fa6cd81 (apache/incubator-hugegraph@ed493f3)

I see, thanks for the reply!~

Note: The project structure in the server has changed, we also need to update it at the same time

image

HTTPS Hugegraph Server fails:

image

image

@simon824
Copy link
Copy Markdown
Member

simon824 commented Dec 5, 2023

It seems to be caused by this pr which removed the -k curl parameter.

updated in e8fb2696d6154f20fd4d6e45ca58763e69145116

@imbajin
Copy link
Copy Markdown
Member

imbajin commented Dec 7, 2023

due to related PR changes by DanGuge

currently the latest CI will fail due to the inconsistency, @DanGuge are u free to address the related client test adaptor? Thanks a lot~

img_v3_025t_d70bc339-a71e-4df4-9e42-090fa560e8bg

DanGuge added a commit to DanGuge/incubator-hugegraph-toolchain that referenced this pull request Dec 9, 2023
@simon824
Copy link
Copy Markdown
Member

simon824 commented Dec 9, 2023

refer to #550

@simon824 simon824 closed this Dec 9, 2023
DanGuge added a commit to DanGuge/incubator-hugegraph-toolchain that referenced this pull request Dec 12, 2023
simon824 added a commit that referenced this pull request Dec 12, 2023
* update tests with new traverser apis

* remove print

* license header fixed

* pick from #542

* update paths

* ignore test in client

* ignore test in client

* update commit id

* fix names & tests

* remote plugin from pom

* fix token & ignore testCountWithProperties first

* feat(tool):hg client support new metric api

* update commit id

* Update client-go-ci.yml

---------

Co-authored-by: imbajin <[email protected]>
Co-authored-by: 1289220708 <[email protected]>
Co-authored-by: Simon Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client hugegraph-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants