Skip to content

support negative number for index#513

Merged
Linary merged 3 commits intomasterfrom
neg-index
Jun 4, 2019
Merged

support negative number for index#513
Linary merged 3 commits intomasterfrom
neg-index

Conversation

@javeme
Copy link
Copy Markdown
Contributor

@javeme javeme commented May 15, 2019

Change-Id: I7067cfb0a663e89ae4305425edf00e6a2a03587c
implement: #311

@codecov
Copy link
Copy Markdown

codecov bot commented May 22, 2019 •
edited
Loading

Codecov Report

Merging #513 into master will increase coverage by 0.09%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
+ Coverage     70.09%   70.18%   +0.09%     
- Complexity     3410     3415       +5     
============================================
  Files           216      216              
  Lines         16503    16448      -55     
  Branches       2360     2350      -10     
============================================
- Hits          11567    11544      -23     
+ Misses         3678     3649      -29     
+ Partials       1258     1255       -3
Impacted Files Coverage Δ Complexity Δ
...idu/hugegraph/backend/store/hbase/HbaseTables.java 85% <ø> (+25.35%) 0 <0> (ø) ⬇️
...aph/backend/store/postgresql/PostgresqlTables.java 91.37% <100%> (ø) 1 <0> (ø) ⬇️
...hugegraph/backend/serializer/BinarySerializer.java 80.1% <100%> (ø) 102 <0> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 76.76% <100%> (+0.31%) 70 <4> (+1) ⬆️
...idu/hugegraph/backend/store/mysql/MysqlTables.java 86.86% <100%> (ø) 1 <0> (ø) ⬇️
...java/com/baidu/hugegraph/type/define/DataType.java 89.85% <66.66%> (-2.69%) 36 <0> (+2)
...gegraph/backend/store/memory/InMemoryDBTables.java 75.84% <87.5%> (-2.58%) 0 <0> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.52% <0%> (-0.32%) 146% <0%> (+1%)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 82.26% <0%> (+0.14%) 209% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abebfac...c0685fd. Read the comment docs.

@javeme javeme force-pushed the neg-index branch 27 times, most recently from f2d142a to acba4ab Compare May 30, 2019 07:14
Linary
Linary requested changes May 31, 2019
View reviewed changes
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/memory/InMemoryDBTables.java Outdated
boolean keyMinEq) {
NavigableMap<Id, BackendEntry> rs = this.store();

E.checkArgument(!(keyMin == null && keyMax == null),
Copy link
Copy Markdown
Contributor

@Linary Linary May 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems keyMin != null || keyMax != null more readable

javeme added 3 commits June 3, 2019 17:11
@javeme
support negative number for index
5a9bf64 
Change-Id: I7067cfb0a663e89ae4305425edf00e6a2a03587c
implement: #311
@javeme
fix inaccurate value with decimal type
34a1e95 
Change-Id: Ie4f7af7083628b44f605944a014a2e5443d4767d
@javeme
tiny improve
c0685fd 
Change-Id: I5ee00eab8808d2f0a447346cac785764369670b9
@Linary Linary merged commit f3a3c35 into master Jun 4, 2019
@Linary Linary deleted the neg-index branch June 4, 2019 02:41
@zhoney zhoney mentioned this pull request Jun 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Linary Linary Linary approved these changes

@zhoney zhoney zhoney approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javeme @Linary @zhoney