Skip to content

chore(store): translate CJK comments to English for store-cli, store-client, store-common, store-core#2623

Merged
JackyYangPassion merged 7 commits intomasterfrom
trans-store
Aug 10, 2024
Merged

chore(store): translate CJK comments to English for store-cli, store-client, store-common, store-core#2623
JackyYangPassion merged 7 commits intomasterfrom
trans-store

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies commented Aug 6, 2024

subtask of #2575

Copy link
Copy Markdown
Contributor Author

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions batch 1

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.04%. Comparing base (2e27c58) to head (70e9628).

Files Patch % Lines
.../hugegraph/store/business/BusinessHandlerImpl.java 0.00% 3 Missing ⚠️
...org/apache/hugegraph/store/raft/RaftOperation.java 0.00% 3 Missing ⚠️
...va/org/apache/hugegraph/store/PartitionEngine.java 0.00% 2 Missing ⚠️
.../apache/hugegraph/store/meta/PartitionManager.java 0.00% 2 Missing ⚠️
...in/java/org/apache/hugegraph/store/meta/Store.java 0.00% 2 Missing ⚠️
...java/org/apache/hugegraph/store/HgStoreEngine.java 0.00% 1 Missing ⚠️
...ache/hugegraph/store/pd/FakePdServiceProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2623      +/-   ##
============================================
- Coverage     45.42%   44.04%   -1.39%     
- Complexity      343      676     +333     
============================================
  Files           718      718              
  Lines         58441    58441              
  Branches       7492     7492              
============================================
- Hits          26549    25739     -810     
- Misses        29175    30067     +892     
+ Partials       2717     2635      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor Author

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions batch 2

@VGalaxies VGalaxies marked this pull request as ready for review August 6, 2024 13:16
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 6, 2024
@VGalaxies VGalaxies requested a review from imbajin August 6, 2024 13:16
@dosubot dosubot bot added the store Store module label Aug 6, 2024
Copy link
Copy Markdown
Contributor

@Pengzna Pengzna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

LLM yes, Go**gle translator s**t

image

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@JackyYangPassion JackyYangPassion merged commit c231a6f into master Aug 10, 2024
@JackyYangPassion JackyYangPassion deleted the trans-store branch August 10, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. store Store module

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants