Skip to content

doc(server): enhance rest-server.properties comment#2610

Merged
imbajin merged 5 commits intoapache:masterfrom
Thespica:refine-port-doc
Aug 2, 2024
Merged

doc(server): enhance rest-server.properties comment#2610
imbajin merged 5 commits intoapache:masterfrom
Thespica:refine-port-doc

Conversation

@Thespica
Copy link
Copy Markdown
Contributor

@Thespica Thespica commented Aug 1, 2024

Purpose of the PR

refine documentation about rest bind url.

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 1, 2024
Comment on lines +2 to +3
# http://0.0.0.0:8080 to listen all network interfaces, but need to take care of security
# or listen to specific IP with port
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# http://0.0.0.0:8080 to listen all network interfaces, but need to take care of security
# or listen to specific IP with port
# could use '0.0.0.0' or specified (real)IP to expose external network access

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 2, 2024
@imbajin imbajin requested a review from VGalaxies August 2, 2024 07:48
@imbajin imbajin changed the title chore: refine rest-server.property documentation doc(server): enhance rest-server.properties comment Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants