Skip to content

chore(pd): refactor and fix pd tests#2492

Merged
imbajin merged 8 commits intopd-storefrom
fix-pd-test
Apr 3, 2024
Merged

chore(pd): refactor and fix pd tests#2492
imbajin merged 8 commits intopd-storefrom
fix-pd-test

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies commented Mar 22, 2024

subtask of #2481


  1. remove pd-clitools module (replace with pd-cli when adapting 4.0)
  2. fix code style
  3. remove useless test classes, such as DiscoveryClientImplTest, although DiscoveryClientImpl is still retained in pd-client
  4. all core tests inherit from PDCoreTestBase to reuse the PDConfig construction

For detailed documentation, please refer to this link.

@VGalaxies VGalaxies self-assigned this Mar 22, 2024
@VGalaxies VGalaxies added the pd PD module label Mar 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (pd-store@6d04e9b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...va/org/apache/hugegraph/pd/client/ClientCache.java 14.28% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             pd-store    #2492   +/-   ##
===========================================
  Coverage            ?   56.82%           
  Complexity          ?     2156           
===========================================
  Files               ?      717           
  Lines               ?    58318           
  Branches            ?     7482           
===========================================
  Hits                ?    33140           
  Misses              ?    21943           
  Partials            ?     3235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VGalaxies VGalaxies marked this pull request as ready for review March 22, 2024 13:17
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 22, 2024
@VGalaxies VGalaxies requested a review from imbajin March 22, 2024 13:17
@dosubot dosubot bot added the tests Add or improve test cases label Mar 22, 2024
Copy link
Copy Markdown
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relative doc & previous issues help me a lot :)

Miss some context before reading them

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 3, 2024
@imbajin imbajin merged commit 50ae4de into pd-store Apr 3, 2024
@imbajin imbajin deleted the fix-pd-test branch April 3, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer pd PD module size:XXL This PR changes 1000+ lines, ignoring generated files. tests Add or improve test cases

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants