Skip to content

fix(pd-store): partially fix hstore backend core tests failure#2424

Merged
VGalaxies merged 4 commits intopd-storefrom
fix-hstore-ci
Jan 29, 2024
Merged

fix(pd-store): partially fix hstore backend core tests failure#2424
VGalaxies merged 4 commits intopd-storefrom
fix-hstore-ci

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies commented Jan 21, 2024 •
edited
Loading

Purpose of the PR

close #2420

Main Changes

Some tests that are currently failing (not addressed in this PR):

  1. Tests related to OLAP in VertexCoreTest: Not adapted yet.
  2. Tests related to page in VertexCoreTest and EdgeCoreTest: Inconsistency in the definition of position between RocksDB scan iterator and Hstore.
  3. Some RamTableTest cases: The ramtable feature is not supported by the hstore backend.
  4. ...

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • CI

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@VGalaxies VGalaxies added the hstore Hstore backend label Jan 21, 2024
@VGalaxies VGalaxies self-assigned this Jan 21, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working tests Add or improve test cases labels Jan 21, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (pd-store@499f8e7). Click here to learn what that means.

Additional details and impacted files 
@@             Coverage Diff             @@
##             pd-store    #2424   +/-   ##
===========================================
  Coverage            ?   55.15%           
  Complexity          ?     1901           
===========================================
  Files               ?      718           
  Lines               ?    58294           
  Branches            ?     7484           
===========================================
  Hits                ?    32150           
  Misses              ?    22974           
  Partials            ?     3170

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies VGalaxies marked this pull request as draft January 22, 2024 15:17
@VGalaxies
Copy link
Copy Markdown
Contributor Author

VGalaxies commented Jan 22, 2024 •
edited
Loading

@Pengzna, could you take a look at the errors related to MultiGraphsTest and EdgeCoreTest?

@Pengzna
Copy link
Copy Markdown
Contributor

Pengzna commented Jan 23, 2024

@Pengzna, could you take a look at the errors related to MultiGraphsTest and EdgeCoreTest?

Thanks your work, I'm working on it

@VGalaxies VGalaxies mentioned this pull request Jan 23, 2024
Closed
26 tasks
@VGalaxies
Copy link
Copy Markdown
Contributor Author

VGalaxies commented Jan 29, 2024

@Pengzna, could you take a look at the errors related to MultiGraphsTest and EdgeCoreTest?

Thanks your work, I'm working on it

enhance it in next PR~

@VGalaxies VGalaxies changed the title fix(pd-store): hstore backend core tests failure (WIP) fix(pd-store): partial fix hstore backend core tests failure Jan 29, 2024
@VGalaxies VGalaxies changed the title fix(pd-store): partial fix hstore backend core tests failure fix(pd-store): partially fix hstore backend core tests failure Jan 29, 2024
@VGalaxies VGalaxies marked this pull request as ready for review January 29, 2024 14:48
@VGalaxies VGalaxies merged commit 46cb612 into pd-store Jan 29, 2024
@VGalaxies VGalaxies deleted the fix-hstore-ci branch January 29, 2024 14:49
@Pengzna Pengzna mentioned this pull request Jan 29, 2024
Merged
@VGalaxies VGalaxies mentioned this pull request Feb 27, 2024
Open
@VGalaxies VGalaxies mentioned this pull request Mar 16, 2024
Closed
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 20, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VGalaxies VGalaxies

Labels

bug Something isn't working hstore Hstore backend size:M This PR changes 30-99 lines, ignoring generated files. tests Add or improve test cases

Projects

HugeGraph PD-Store Tasks
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VGalaxies @Pengzna