Skip to content

fix(auth): enhance the URL check#2422

Merged
VGalaxies merged 5 commits intomasterfrom
feat_security
Mar 9, 2024
Merged

fix(auth): enhance the URL check#2422
VGalaxies merged 5 commits intomasterfrom
feat_security

Conversation

@zyxxoo
Copy link
Copy Markdown
Contributor

@zyxxoo zyxxoo commented Jan 19, 2024

No description provided.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. api Changes of API bug Something isn't working labels Jan 19, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.31%. Comparing base (eb6570c) to head (7fb1a00).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2422      +/-   ##
============================================
+ Coverage     66.26%   66.31%   +0.04%     
  Complexity      827      827              
============================================
  Files           511      511              
  Lines         42623    42624       +1     
  Branches       5947     5947              
============================================
+ Hits          28245    28264      +19     
+ Misses        11563    11553      -10     
+ Partials       2815     2807       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title fix: security bug fix(auth): enhance the way to check whitelist Jan 19, 2024
@imbajin imbajin added security and removed bug Something isn't working labels Jan 19, 2024

for (String whiteApi : WHITE_API_LIST) {
if (path.endsWith(whiteApi)) {
if (MATCHER.match(whiteApi, path)) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add some tests for it

@imbajin imbajin changed the title fix(auth): enhance the way to check whitelist fix(auth): enhance the URL check Feb 29, 2024
@SunnyBoy-WYH
Copy link
Copy Markdown
Contributor

seems this pr will also solve #2176

javeme
javeme previously approved these changes Mar 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 3, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 8, 2024
imbajin
imbajin previously approved these changes Mar 8, 2024

- [ ] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Dependencies ([add/update license](https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses) info & [regenerate_dependencies](../hugegraph-server/hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh)) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon824 update here

@imbajin imbajin requested a review from simon824 March 8, 2024 08:59
@VGalaxies VGalaxies merged commit c09982b into master Mar 9, 2024
@VGalaxies VGalaxies deleted the feat_security branch March 9, 2024 13:04
VGalaxies pushed a commit that referenced this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Changes of API lgtm This PR has been approved by a maintainer security size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants