Skip to content

fix: incorrect path in hugegraph assembly scripts#2392

Merged
simon824 merged 3 commits intoapache:masterfrom
VGalaxies:fix-assemble
Dec 18, 2023
Merged

fix: incorrect path in hugegraph assembly scripts#2392
simon824 merged 3 commits intoapache:masterfrom
VGalaxies:fix-assemble

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

Purpose of the PR

I noticed that the binary packages built by HugeGraph are missing the DISCLAIMER, LICENSE, NOTICE files, and the licenses directory. Therefore, I fixed the corresponding assembly.xml script.

I also renamed the README file in the docker folder.

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb4427d) 66.27% compared to head (7b6a9a2) 66.25%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2392      +/-   ##
============================================
- Coverage     66.27%   66.25%   -0.02%     
  Complexity      828      828              
============================================
  Files           511      511              
  Lines         42590    42590              
  Branches       5941     5941              
============================================
- Hits          28225    28218       -7     
- Misses        11556    11557       +1     
- Partials       2809     2815       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch~

@simon824 simon824 merged commit 965d6c1 into apache:master Dec 18, 2023
@VGalaxies VGalaxies deleted the fix-assemble branch December 18, 2023 04:58
VGalaxies added a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024
* fix: typo

* fix: assembly hugegraph path

* reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants