chore(server): update license for 1.2.0#2391
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2391 +/- ##
============================================
+ Coverage 66.27% 66.29% +0.02%
+ Complexity 830 828 -2
============================================
Files 511 511
Lines 42590 42590
Branches 5941 5941
============================================
+ Hits 28227 28237 +10
+ Misses 11558 11550 -8
+ Partials 2805 2803 -2 ☔ View full report in Codecov by Sentry. |
imbajin
left a comment
imbajin
left a comment
There was a problem hiding this comment.
Thanks~
But too big to review the details in UI, search it in local IDE soon
Do we have any pre-check tool to vertify it? so we can dont need check until release landing. |
|
@SunnyBoy-WYH We need also declare or remove the LICENSE information of the dependencies in the ./hugegraph-dist/release-docs/LICENSE like this PR https://github.com/apache/incubator-hugegraph-toolchain/pull/561/files#diff-51058cf24ef5a02a1ee2309fd4428e716d1e24e08dafa82025c4a54c3f9084c7 |
| Permission to use, copy, modify, and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the above copyright notice appear in all copies and that both the copyright notice and this permission notice and warranty disclaimer appear in supporting documentation, and that the names of the authors or their employers not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. | ||
|
|
||
| The authors and their employers disclaim all warranties with regard to this software, including all implied warranties of merchantability and fitness. In no event shall the authors or their employers be liable for any special, indirect or consequential damages or any damages whatsoever resulting from loss of use, data or profits, whether in an action of contract, negligence or other tortious action, arising out of or in connection with the use or performance of this software. | ||
| This is an open source license. It is also GPL-Compatible (see entry for "Standard ML of New Jersey"). The portions of CUP output which are hard-coded into the CUP source code are (naturally) covered by this same license, as is the CUP runtime code linked with the generated parser. |
There was a problem hiding this comment.
It seems that it is not clear from the file what license this dependency is based on. And this license contains GPL keywords, which should be noted and removed.
There was a problem hiding this comment.
It seems that it is not clear from the file what license this dependency is based on. And this license contains
GPLkeywords, which should be noted and removed.
consider remove the unnecessary NOTICE part from upstream
--------- Co-authored-by: liuxiao <[email protected]> Co-authored-by: Simon Cheung <[email protected]>
4 participants
Purpose of the PR
hugegraph/actions#6
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need