doc: adjust docker desc in readme#2390
Merged
simon824 merged 8 commits intoapache:masterfrom Dec 17, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2390 +/- ##
============================================
- Coverage 66.27% 66.21% -0.07%
+ Complexity 830 828 -2
============================================
Files 511 511
Lines 42590 42590
Branches 5941 5941
============================================
- Hits 28227 28201 -26
- Misses 11558 11576 +18
- Partials 2805 2813 +8 ☔ View full report in Codecov by Sentry. |
aroundabout
changed the title
aroundabout
changed the title
javeme
reviewed
Dec 16, 2023
hugegraph-server/hugegraph-dist/docker/scripts/detect-storage.groovy
Outdated
Show resolved
Hide resolved
aroundabout
commented
Dec 16, 2023
hugegraph-server/hugegraph-dist/docker/scripts/detect-storage.groovy
Outdated
Show resolved
Hide resolved
imbajin
reviewed
Dec 16, 2023
README.md
Outdated
| ### 2. Download Way | ||
| ### 1. Download Way | ||
|
|
||
| Visit [Download Page](https://hugegraph.apache.org/docs/download/download/) and refer the [doc](https://hugegraph.apache.org/docs/quickstart/hugegraph-server/#33-source-code-compilation) |
Member
There was a problem hiding this comment.
seems the refer doc is not for binary release? (use binary pkg instruction link here)
Contributor
Author
There was a problem hiding this comment.
seems the refer doc is not for binary release? (use binary pkg instruction link here)
Changed.
But it should be adjusted to sync the doc again (in doc the order of how to get hugegraph will be changed)
Comment on lines
-296
to
-311
| <!-- copy the artifacts to root | ||
| directory for better user experience --> | ||
| <!-- REMOVE ME after revision 1.5.0 --> | ||
| <exec executable="cp" | ||
| dir="${project.basedir}" | ||
| failonerror="false"> | ||
| <arg value="-r"/> | ||
| <arg value="../${final.name}"/> | ||
| <arg value="../../${final.name}"/> | ||
| </exec> | ||
| <exec executable="cp" | ||
| dir="${project.basedir}" | ||
| failonerror="false"> | ||
| <arg value="../${final.name}.tar.gz"/> | ||
| <arg value="../../${final.name}.tar.gz"/> | ||
| </exec> |
Member
There was a problem hiding this comment.
Description: due to we already have the release script in dist module, we don't need cp the pkg now
imbajin
approved these changes
Dec 16, 2023
imbajin
reviewed
Dec 16, 2023
| procps \ | ||
| curl \ | ||
| lsof \ | ||
| vim \ |
Member
There was a problem hiding this comment.
TODO: consider replace with nano or use a more slime way to install it
simon824
approved these changes
Dec 17, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Jan 12, 2024
* fix(dist): update relative path for the 1.2.0 * add docker policy and run server in daemon * fix: use tail to avoid container exit * adjuest the order of quick start * Update hugegraph-server/hugegraph-dist/docker/scripts/detect-storage.groovy * adjust desc * Update README.md * Update pom.xml --------- Co-authored-by: imbajin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need