chore(ci): add stage profile settings#2361
Merged
simon824 merged 11 commits intoapache:masterfrom Nov 28, 2023
Zony7:chore-branch
Merged
chore(ci): add stage profile settings#2361simon824 merged 11 commits intoapache:masterfrom Zony7:chore-branch
simon824 merged 11 commits intoapache:masterfrom
Zony7:chore-branch
Conversation
imbajin
reviewed
Nov 23, 2023
Comment on lines
+32
to
+37
| - name: use staged maven repo settings | ||
| if: ${{ env.USE_STAGE == 'true' }} | ||
| run: | | ||
| cp $HOME/.m2/settings.xml /tmp/settings.xml | ||
| mv -vf .github/configs/settings.xml $HOME/.m2/settings.xml | ||
|
|
Member
There was a problem hiding this comment.
seems no need in license-check?
Contributor
Author
There was a problem hiding this comment.
I also feel that it is not necessary, but it's in this PR. I will remove it, think you!
Member
Contributor
Author
There was a problem hiding this comment.
I will fix it ,think you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
=========================================
Coverage 65.88% 65.88%
Complexity 826 826
=========================================
Files 507 507
Lines 42073 42073
Branches 5831 5831
=========================================
+ Hits 27720 27721 +1
Misses 11595 11595
+ Partials 2758 2757 -1 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Nov 23, 2023
| @@ -12,6 +12,7 @@ jobs: | |||
| build: | |||
| runs-on: ubuntu-20.04 | |||
Member
There was a problem hiding this comment.
TODO: In next ci enhancement PR, we could try ubuntu-latest or at least a new LTS version to avoid running in outdated env
imbajin
approved these changes
Nov 28, 2023
simon824
approved these changes
Nov 28, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Jan 12, 2024
* Update LICENSE * Update install-cassandra.sh * add stage profile settings * Update ci.yml * Update ci.yml * Update ci.yml * Update licence-checker.yml --------- Co-authored-by: imbajin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need