Skip to content

chore(ci): add stage profile settings#2361

Merged
simon824 merged 11 commits intoapache:masterfrom
Zony7:chore-branch
Nov 28, 2023
Merged

chore(ci): add stage profile settings#2361
simon824 merged 11 commits intoapache:masterfrom
Zony7:chore-branch

Conversation

@Zony7
Copy link
Copy Markdown
Contributor

@Zony7 Zony7 commented Nov 23, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Comment on lines +32 to +37
- name: use staged maven repo settings
if: ${{ env.USE_STAGE == 'true' }}
run: |
cp $HOME/.m2/settings.xml /tmp/settings.xml
mv -vf .github/configs/settings.xml $HOME/.m2/settings.xml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems no need in license-check?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also feel that it is not necessary, but it's in this PR. I will remove it, think you!

Copy link
Copy Markdown
Member

@imbajin imbajin Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR

Get the problem, and hubble ci do need it (now put it in a wrong place)
image

And I'll fix the problem

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems changed wrong place?
image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it ,think you!

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0ea21e) 65.88% compared to head (44a77fe) 65.88%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2361   +/-   ##
=========================================
  Coverage     65.88%   65.88%           
  Complexity      826      826           
=========================================
  Files           507      507           
  Lines         42073    42073           
  Branches       5831     5831           
=========================================
+ Hits          27720    27721    +1     
  Misses        11595    11595           
+ Partials       2758     2757    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -12,6 +12,7 @@ jobs:
build:
runs-on: ubuntu-20.04
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: In next ci enhancement PR, we could try ubuntu-latest or at least a new LTS version to avoid running in outdated env

@simon824 simon824 merged commit 197e8a0 into apache:master Nov 28, 2023
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024
* Update LICENSE

* Update install-cassandra.sh

* add stage profile settings

* Update ci.yml

* Update ci.yml

* Update ci.yml

* Update licence-checker.yml

---------

Co-authored-by: imbajin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants