fix: remove redirect-to-master from synchronous Gremlin API#2356
Merged
imbajin merged 2 commits intoapache:masterfrom Nov 22, 2023
Merged
fix: remove redirect-to-master from synchronous Gremlin API#2356imbajin merged 2 commits intoapache:masterfrom
imbajin merged 2 commits intoapache:masterfrom
Conversation
qwtsc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2356 +/- ##
============================================
+ Coverage 64.32% 67.91% +3.58%
+ Complexity 981 678 -303
============================================
Files 507 507
Lines 42073 42073
Branches 5831 5831
============================================
+ Hits 27065 28573 +1508
+ Misses 12317 10737 -1580
- Partials 2691 2763 +72 ☔ View full report in Codecov by Sentry. |
Member
|
THX, shall we also address the #2355 (comment) ? |
javeme
changed the title
javeme
approved these changes
Nov 21, 2023
Contributor
javeme
left a comment
javeme
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for your analysis and fix~
Contributor
Author
I think we need think about it carefully as it may result in more unpredictable concurrency safety issues such as issue if any node can do modifications to vertex label schema. |
zyxxoo
approved these changes
Nov 21, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Jan 12, 2024
…2356) * fix: remove redirect master role to align with behaviour of VertexApi and EdgeApi * chore: add back necessary annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
see the discussion in #2355
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need