fix: in wait-storage.sh, always wait for storage with default rocksdb #2333
Merged
simon824 merged 1 commit intoapache:masterfrom Oct 24, 2023
Merged
fix: in wait-storage.sh, always wait for storage with default rocksdb #2333simon824 merged 1 commit intoapache:masterfrom
simon824 merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2333 +/- ##
============================================
- Coverage 61.50% 53.34% -8.16%
- Complexity 494 662 +168
============================================
Files 505 505
Lines 41902 41902
Branches 5817 5817
============================================
- Hits 25771 22354 -3417
- Misses 13506 17176 +3670
+ Partials 2625 2372 -253 see 150 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
approved these changes
Oct 24, 2023
simon824
approved these changes
Oct 24, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Nov 10, 2023
imbajin
pushed a commit
that referenced
this pull request
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Add a condition whether there are no changes about the graph config.
If no changes, then server use the embedded rocksdb to store data without waiting for storage.
Now:
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need