Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2331 +/- ##
============================================
+ Coverage 63.85% 64.93% +1.08%
- Complexity 684 987 +303
============================================
Files 505 505
Lines 41902 41902
Branches 5817 5817
============================================
+ Hits 26756 27210 +454
+ Misses 12455 12000 -455
- Partials 2691 2692 +1 see 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
previously approved these changes
Oct 21, 2023
javeme
reviewed
Oct 22, 2023
hugegraph-dist/README.md
Outdated
| 2. Using docker compose | ||
|
|
||
| We can also use `docker-compose up -d`. The `docker-compose.yaml` is below: | ||
| Additionally, if we want to manage other Hugegraph-related instances with `server` in a single file, we can also use docker-compose for deployment. (Certainly we can only deploy server without other instance) We can also use `docker-compose up -d`. The `docker-compose.yaml` is below: |
Contributor
There was a problem hiding this comment.
- Hugegraph-related => HugeGraph-related.
- "(Certainly we can only deploy server without other instance)" -- move to the first line? like "Certainly We can deploy server without other instances. Additionally we can also ...".
- To deploy HugeGraph-related instances via
docker-compose up -d. - "is below" => "is as below"
imbajin
approved these changes
Oct 23, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Nov 10, 2023
imbajin
pushed a commit
that referenced
this pull request
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need