chore: enhance a string of problems to pass CI#2321
chore: enhance a string of problems to pass CI#2321imbajin merged 31 commits intoapache:pd-storefrom
Conversation
Codecov Report
@@ Coverage Diff @@
## pd-store #2321 +/- ##
===========================================
Coverage ? 56.49%
Complexity ? 2181
===========================================
Files ? 700
Lines ? 55741
Branches ? 7144
===========================================
Hits ? 31490
Misses ? 21187
Partials ? 3064 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This reverts commit 6baba56.
package org.apache.hugegraph.pd.boot does not exist
except hg-store-node and hg-store-rocksdb
object is not an instance of declaring class
There was a problem hiding this comment.
why remove them? Non-maven user could use it to build maven project
However, we should only put one on the top of the project(and remove it for sub-module)
There was a problem hiding this comment.
This is because there is no similar wrapper for the hugegraph-server, and it might affect the license checker.
Will try to add it later.
There was a problem hiding this comment.
This is because there is no similar wrapper for the hugegraph-server, and it might affect the license checker.
Will try to add it later.
Yep, because the server module lack this function, could refer other apache project later (like license problem)
Better add a todo item in summary issue
| // @Test | ||
| public void testHashCode() { | ||
| int partCount = 10; | ||
| int partSize = PartitionUtils.MAX_VALUE / partCount + 1; | ||
| int[] counter = new int[partCount]; | ||
| for (int i = 0; i < 10000; i++) { | ||
| String s = String.format("BATCH-GET-UNIT-%02d", i); | ||
| int c = PartitionUtils.calcHashcode(s.getBytes(StandardCharsets.UTF_8)); | ||
|
|
||
| counter[c / partSize]++; | ||
|
|
||
| } | ||
|
|
||
| for (int i = 0; i < counter.length; i++) { | ||
| System.out.println(i + " " + counter[i]); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Migrated from the corresponding class in the testing directory of a sub-module under hugegraph-pd. Awaiting further adaptation in the next step.
hugegraph-store/hg-store-test/src/main/java/org/apache/hugegraph/store/util/UnsafeUtilTest.java
Outdated
Show resolved
Hide resolved
imbajin
left a comment
imbajin
left a comment
There was a problem hiding this comment.
we could fix 3rd-party problem together in the fixed version
2 participants
Purpose of the PR
subtask of #2265
Ensure that the CI for the
pd-storebranch runs successfully.Main Changes
ci.yml(not support java 8 in HugeGraph 1.5.0)pd-store.ymlfor pd, store, hstore UThg-pd-testmodule, the same for storehg-pd-service,hg-store-node,hg-store-rocksdbTODO
known-dependencies.txtfile inhugegraph-server/hugegraph-dist/scripts/dependency/)hugegraph-server/hugegraph-distmay need to be relocated to the appropriate locations. 🤔hugegraph-server/hugegraph-dist/src/assembly/jenkins/Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need