Skip to content

fix: license check errors #2303

Closed
msgui wants to merge 4 commits intoapache:pd-storefrom
msgui:fix-license
Closed

fix: license check errors #2303
msgui wants to merge 4 commits intoapache:pd-storefrom
msgui:fix-license

Conversation

@msgui
Copy link
Copy Markdown
Contributor

@msgui msgui commented Aug 30, 2023

Purpose of the PR

  • fix license check errors

img_v2_c5e2d726-d055-4c90-a494-c65270bc163g

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@msgui msgui marked this pull request as draft August 30, 2023 08:47
@msgui msgui requested a review from imbajin September 2, 2023 14:55
Copy link
Copy Markdown
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still in progress?

@github-actions
Copy link
Copy Markdown

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

imbajin pushed a commit that referenced this pull request Oct 16, 2023
## Main Changes

- fix license header (from #2303)
	- remove maven wrapper in pd and store
- remove java 8 CI in `ci.yml` (not support java 8 in HugeGraph 1.5.0)
- add `pd-store.yml` for pd, store, hstore UT
- collect the test files from pd into the `hg-pd-test` module, the same for store
	- except for `hg-pd-service`, `hg-store-node`, `hg-store-rocksdb`

## TODO

- [ ] dependency-check (update the `known-dependencies.txt` file in `hugegraph-server/hugegraph-dist/scripts/dependency/`)
	- [ ] With the change in project structure, some scripts in `hugegraph-server/hugegraph-dist` may need to be relocated to the appropriate locations. 🤔
- [ ] `hugegraph-server/hugegraph-dist/src/assembly/jenkins/`
@imbajin
Copy link
Copy Markdown
Member

imbajin commented Nov 28, 2023

merged it in #2321

@imbajin imbajin closed this Nov 28, 2023
@msgui msgui deleted the fix-license branch March 15, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants