feat(api): support embedded arthas agent in hugegraph-server by SunnyBoy-WYH · Pull Request #2278 · apache/hugegraph

SunnyBoy-WYH · 2023-08-12T15:28:04Z

目的：增加 Arthas server 内嵌服务接口 (也就是说启动 HG Server 后可以直接使用 Arthas 动态观测/perf/debug, 无需单独安装)

流程：

好处：
1.一键启动Arthas后，可使用 Arthas 动态观测，无需单独安装
2.docker版本hugeGraph实现内嵌arthas

测试：
启动

http api方式与arthas交互

hugegraph-dist/src/assembly/static/conf/arthas.yaml

hugegraph-dist/src/assembly/static/conf/rest-server.properties

hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java

imbajin · 2023-08-12T17:10:07Z

also refer the contribution-doc in website to fix the 3rd-party info (fix ci problems)

codecov · 2023-08-12T17:14:24Z

Codecov Report

Merging #2278 (f3f9d48) into master (30ef2f7) will increase coverage by 0.24%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2278      +/-   ##
============================================
+ Coverage     64.70%   64.95%   +0.24%     
+ Complexity      989      987       -2     
============================================
  Files           501      505       +4     
  Lines         41601    41902     +301     
  Branches       5799     5817      +18     
============================================
+ Hits          26917    27216     +299     
+ Misses        12002    11994       -8     
- Partials       2682     2692      +10

Files	Coverage Δ
...ava/org/apache/hugegraph/api/arthas/ArthasAPI.java	`100.00% <100.00%> (ø)`
...ava/org/apache/hugegraph/config/ServerOptions.java	`100.00% <100.00%> (ø)`

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin · 2023-08-16T17:46:04Z

also refer the contribution-doc in website to fix the 3rd-party info (fix ci problems)

we need handle the 3rd-party issues~

SunnyBoy-WYH · 2023-08-17T08:39:12Z

also refer the contribution-doc in website to fix the 3rd-party info (fix ci problems)

we need handle the 3rd-party issues~

noted, thanks jin, i am learning how to solve it~

imbajin · 2023-08-21T10:31:22Z

need handle the conflicts now. so as another PR

# Conflicts: # hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

imbajin · 2023-08-22T07:12:14Z

seems the PG CI always failed

SunnyBoy-WYH · 2023-08-23T16:06:07Z

seems the PG CI always failed

seems time exceeded？https://github.com/apache/incubator-hugegraph/actions/runs/5927042184?pr=2278

imbajin · 2023-08-24T10:03:30Z

seems the PG CI always failed

seems time exceeded？apache/incubator-hugegraph/actions/runs/5927042184?pr=2278

Could ignore RocksDB-Raft test, but it's strange that the PG tests always failed..

BTW, add the related doc in website-repo to help others know how to use it THX

SunnyBoy-WYH · 2023-08-26T10:30:56Z

@imbajin

seems pass ci?

simon824

Overall LGTM

hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java

hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java

hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java

hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

javeme · 2023-09-09T03:16:31Z

hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

+    public static final ConfigOption<String> ARTHAS_DISABLED_COMMANDS =
+        new ConfigOption<>(
+            "arthas.disabledCommands",
+            "arthas disabled commands",


could you please add more details for the description, since it will be as a guide for users.

hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

imbajin · 2023-09-20T14:08:08Z

BTW, remember to resolve the outdated conversation:

imbajin

LGTM, Thanks for your contribution (remember add the related doc~)

javeme · 2023-09-23T03:45:23Z

please note the CI Error when Running org.apache.hugegraph.api.ApiTestSuite:
https://github.com/apache/incubator-hugegraph/actions/runs/6262763117/job/17047018545?pr=2278

SunnyBoy-WYH · 2023-09-23T10:38:21Z

please note the CI Error when Running org.apache.hugegraph.api.ApiTestSuite: https://github.com/apache/incubator-hugegraph/actions/runs/6262763117/job/17047018545?pr=2278

seems from rest-server.properties,but i am not changed configure item about auth?

java.lang.AssertionError: Response with status 500 and content {"exception":"class java.lang.IllegalStateException","message":"Unconfigured authenticator, please config auth.authenticator option in rest-server.properties","cause":""}

javeme · 2023-09-24T14:27:03Z

"Unconfigured authenticator, please config auth.authenticator option in rest-server.properties"

You need to enable auth feature to build the test environment if want to run tests locally.

SunnyBoy-WYH · 2023-09-24T14:38:14Z

"Unconfigured authenticator, please config auth.authenticator option in rest-server.properties"

You need to enable auth feature to build the test environment if want to run tests locally.

got it,thanks
but ci faild because apiTestSuite :

i run it local, seems all pass except userapi/loginapi

maybe we need debug mode for github ci?

javeme · 2023-09-30T20:01:20Z

we can log case name or something for every api test case by a @Before method

# Conflicts: # hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

javeme · 2023-10-07T15:41:48Z

The ApiTestSuite still fails, there may be some package conflicts with jraft

hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java

hugegraph-test/src/main/java/org/apache/hugegraph/api/BaseApiTest.java

SunnyBoy-WYH · 2023-10-15T13:40:12Z

Do we have any method to see some log abort the reason for backend-rocksdb raft test failure? i run locally with rocksdb but not found useful info

imbajin

Seems could ignore raft-test? And it always failed now (should handle it separatly)

SunnyBoy-WYH · 2023-10-17T12:09:39Z

handle

it's a common problem? i see 【rocksdb raft ci problem (critical, usually 360min+)】from hg tasks.

javeme

LGTM

…2278)

SunnyBoy-WYH added 3 commits August 10, 2023 23:04

feat:内嵌 arthas 服务接口

e293089

format code

9d51b06

update arthas version

5ed2dfd

SunnyBoy-WYH changed the title ~~Feat：server集成server~~ feat：server内嵌集成Arthas Aug 12, 2023

imbajin reviewed Aug 12, 2023

View reviewed changes

SunnyBoy-WYH changed the title ~~feat：server内嵌集成Arthas~~ feat：hugegraph-server embedded arthas dependency Aug 13, 2023

add arthas test

78592e5

imbajin changed the title ~~feat：hugegraph-server embedded arthas dependency~~ feat(api): support embedded arthas agent in hugegraph-server Aug 16, 2023

SunnyBoy-WYH added 2 commits August 17, 2023 22:50

license info

d550304

license info

17f8e74

Merge branch 'master' into feat-arthas-server

43ed85e

# Conflicts: # hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

imbajin requested review from JackyYangPassion and simon824 August 26, 2023 12:35

simon824 previously approved these changes Sep 5, 2023

View reviewed changes

hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java Outdated Show resolved Hide resolved

javeme reviewed Sep 8, 2023

View reviewed changes

better code

88e0843

SunnyBoy-WYH dismissed simon824’s stale review via 88e0843 September 8, 2023 17:25

javeme reviewed Sep 9, 2023

View reviewed changes

better code

b620102

javeme reviewed Sep 13, 2023

View reviewed changes

hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java Outdated Show resolved Hide resolved

hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java Outdated Show resolved Hide resolved

better code

4a0ec4e

SunnyBoy-WYH added 2 commits September 20, 2023 23:00

arthas version better code

cf0c99b

dep version update

65c7120

imbajin previously approved these changes Sep 22, 2023

View reviewed changes

javeme previously approved these changes Sep 22, 2023

View reviewed changes

Merge branch 'master' into feat-arthas-server

8d11607

# Conflicts: # hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

SunnyBoy-WYH dismissed stale reviews from javeme and imbajin via 8d11607 October 7, 2023 13:11

SunnyBoy-WYH requested review from imbajin, javeme and simon824 October 7, 2023 13:12

fix(api): test arthas for arthas auth

b0ea4e7

SunnyBoy-WYH mentioned this pull request Oct 10, 2023

feat(WIP): add IntMapByDynamicHash #2294

Merged

11 tasks

javeme reviewed Oct 11, 2023

View reviewed changes

SunnyBoy-WYH added 2 commits October 15, 2023 21:01

chore(api): code style for arthas test

564cdc3

chore(api): code style for arthas test

f3f9d48

imbajin approved these changes Oct 17, 2023

View reviewed changes

javeme approved these changes Oct 19, 2023

View reviewed changes

imbajin merged commit 869fc81 into apache:master Oct 20, 2023

VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023

feat(api): support embedded arthas agent in hugegraph-server (apache#…

f351636

…2278)

imbajin pushed a commit that referenced this pull request Nov 10, 2023

feat(api): support embedded arthas agent in hugegraph-server (#2278)

8115325

imbajin mentioned this pull request Apr 14, 2024

如何对Hugegraph-server中的Kneighbor算法的执行过程作profiling。分析算法执行过程中的各个阶段的内存和CPU占用。 #2516

Open

Conversation

SunnyBoy-WYH commented Aug 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imbajin commented Aug 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

imbajin commented Aug 16, 2023

Uh oh!

SunnyBoy-WYH commented Aug 17, 2023

Uh oh!

imbajin commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

imbajin commented Aug 22, 2023

Uh oh!

SunnyBoy-WYH commented Aug 23, 2023

Uh oh!

imbajin commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SunnyBoy-WYH commented Aug 26, 2023

Uh oh!

simon824 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javeme Sep 9, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imbajin commented Sep 20, 2023

Uh oh!

imbajin left a comment

Choose a reason for hiding this comment

Uh oh!

javeme commented Sep 23, 2023

Uh oh!

SunnyBoy-WYH commented Sep 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javeme commented Sep 24, 2023

Uh oh!

SunnyBoy-WYH commented Sep 24, 2023

Uh oh!

javeme commented Sep 30, 2023

Uh oh!

javeme commented Oct 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SunnyBoy-WYH commented Oct 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SunnyBoy-WYH commented Aug 12, 2023 •

edited

Loading

imbajin commented Aug 12, 2023 •

edited

Loading

codecov bot commented Aug 12, 2023 •

edited

Loading

imbajin commented Aug 21, 2023 •

edited

Loading

imbajin commented Aug 24, 2023 •

edited

Loading

SunnyBoy-WYH commented Sep 23, 2023 •

edited

Loading

SunnyBoy-WYH commented Oct 15, 2023 •

edited

Loading