refact: adjust pom structure for directly compiling from root#2275
refact: adjust pom structure for directly compiling from root#2275imbajin merged 9 commits intoapache:pd-storefrom
Conversation
heiyan-2020
changed the title
heiyan-2020
changed the title
heiyan-2020
changed the title
heiyan-2020
changed the title
| <project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> |
There was a problem hiding this comment.
In accordance with the hierarchical structure, the parent of hugegraph-core should be hugegraph-server. However, due to existing discrepancies between the community version of hugegraph-server and the internal version (such as revision), a temporary adjustment has been made for the purpose of building.
There was a problem hiding this comment.
In accordance with the hierarchical structure, the parent of
hugegraph-coreshould behugegraph-server. However, due to existing discrepancies between the community version ofhugegraph-serverand the internal version (such asrevision), a temporary adjustment has been made for the purpose of building.
Update: miss the msg before, and we choose use a new version for all modules
| <maven.compiler.source>11</maven.compiler.source> | ||
| <maven.compiler.target>11</maven.compiler.target> | ||
| <log4j2.version>2.15.0</log4j2.version> | ||
| <top.level.dir>${project.basedir}/..</top.level.dir> |
There was a problem hiding this comment.
WARN: ensure we don't have multi top.level.dir in project (if we have & need use it, add a comment for it)
There was a problem hiding this comment.
Are you suggesting that we should only retain the top.level.dir property in the root pom?
Additionally, provide all the occurrences of it:
| <!-- tinkerpop --> | ||
| <dependency> |
There was a problem hiding this comment.
why we need add tinkerpop dependency here?
@VGalaxies any context?
There was a problem hiding this comment.
As mentioned in the last item of "Main change", tinkerpop is depended on by hg-store-core, and in internal version the dependency is passed on through hugegraph-core which imported as usal maven dependency. But the current temporary solution is that importing hugegraph-core jar package through system dependency. In this way, the dependencies in hugegraph-core cannot be passed on, so the dependencies need to be added again in hg-store-core
There was a problem hiding this comment.
why we need add tinkerpop dependency here?
@VGalaxies any context?
As stated by @heiyan-2020, assuming there are projects A (hg-store-core) and B (hugegraph-core), where project A depends on project B, and project B is a system dependency, the dependencies within project B will not be automatically inherited by project A.
There was a problem hiding this comment.
As mentioned in the last item of "Main change", tinkerpop is depended on by
hg-store-core, and in internal version the dependency is passed on throughhugegraph-corewhich imported as usal maven dependency. But the current temporary solution is that importinghugegraph-corejar package through system dependency. In this way, the dependencies inhugegraph-corecannot be passed on, so the dependencies need to be added again inhg-store-core
@heiyan-2020 get it, but we need add comment/TODO mark here? (maybe in next PR)
so as other temporary changes, otherwise it's pretty easy to forget the context later
3 participants
Purpose of the PR
subtask of #2265
Adjust the pom structure in order to directly build from root.
Main Changes
hugegraph-pdmodule.hugegraph-coreand add it to the pom of store module as system dependencies.(temporal solution)hugegraph-coreto the pom file ofhg-store-core.Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need