Conversation
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
============================================
- Coverage 66.38% 66.36% -0.02%
+ Complexity 978 976 -2
============================================
Files 482 482
Lines 41458 41458
Branches 5889 5889
============================================
- Hits 27520 27512 -8
- Misses 11237 11247 +10
+ Partials 2701 2699 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
approved these changes
Dec 4, 2022
Comment on lines
+26
to
+27
| INSTALL_DIR=${INSTALL_DIR:?"Please open the script then set variable 'INSTALL_DIR' manually"} | ||
| SERVER_PORT=${SERVER_PORT:?"Please open the script then set variable 'SERVER_PORT' manually"} |
Member
There was a problem hiding this comment.
nice catch，test it in ubuntu21 (fine now)
javeme
approved these changes
Dec 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.