Skip to content

chore: update antrun plugin & fix building problem in windows#2038

Merged
zyxxoo merged 6 commits intoapache:masterfrom
seagle-yuan:dist
Dec 1, 2022
Merged

chore: update antrun plugin & fix building problem in windows#2038
zyxxoo merged 6 commits intoapache:masterfrom
seagle-yuan:dist

Conversation

@seagle-yuan
Copy link
Copy Markdown
Contributor

update antrun plugin & fix windows os

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2022

Codecov Report

Merging #2038 (a2e1e71) into master (be6ee38) will increase coverage by 2.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2038      +/-   ##
============================================
+ Coverage     62.37%   64.45%   +2.07%     
+ Complexity      978      675     -303     
============================================
  Files           482      482              
  Lines         41458    41458              
  Branches       5889     5889              
============================================
+ Hits          25861    26723     +862     
+ Misses        13049    12096     -953     
- Partials       2548     2639      +91     
Impacted Files Coverage Δ
...egraph/backend/store/hbase/HbaseStoreProvider.java 0.00% <0.00%> (-100.00%) ⬇️
...hugegraph/backend/store/hbase/HbaseSerializer.java 0.00% <0.00%> (-92.31%) ⬇️
...che/hugegraph/backend/store/hbase/HbaseTables.java 0.00% <0.00%> (-89.86%) ⬇️
...he/hugegraph/backend/store/hbase/HbaseMetrics.java 0.00% <0.00%> (-86.96%) ⬇️
...e/hugegraph/backend/store/hbase/HbaseFeatures.java 0.00% <0.00%> (-83.34%) ⬇️
...ache/hugegraph/backend/store/hbase/HbaseTable.java 0.00% <0.00%> (-76.37%) ⬇️
...ache/hugegraph/backend/store/hbase/HbaseStore.java 0.00% <0.00%> (-75.88%) ⬇️
...e/hugegraph/backend/store/hbase/HbaseSessions.java 0.00% <0.00%> (-60.60%) ⬇️
.../apache/hugegraph/backend/tx/GraphTransaction.java 80.14% <0.00%> (+0.20%) ⬆️
.../main/java/org/apache/hugegraph/task/HugeTask.java 72.22% <0.00%> (+0.30%) ⬆️
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin changed the title update antrun plugin & fix windows os chore: update antrun plugin & fix building problem in windows Nov 29, 2022
</exec>
</tasks>
<target>
<tar destfile="${top.level.dir}/${final.name}.tar.gz" basedir="${top.level.dir}" includes="${final.name}/*" compression="gzip"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can wrap line for every property?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this
image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Copy Markdown
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it compatible in macOS & win & linux?

which OS env do u test already?

@zyxxoo zyxxoo merged commit 927b673 into apache:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants