Skip to content

[improve] Shutdown log when shutdown process#2028

Merged
javeme merged 1 commit intomasterfrom
improve_log_shutdown
Nov 22, 2022
Merged

[improve] Shutdown log when shutdown process#2028
javeme merged 1 commit intomasterfrom
improve_log_shutdown

Conversation

@coderzc
Copy link
Copy Markdown
Member

@coderzc coderzc commented Nov 22, 2022 •
edited
Loading

Motivation

If set immediateFlush="false" and log size < bufferSize log can't flush to file, we should call LogManager.shutdown() when shutdown process ensures log flush to file.
https://github.com/apache/incubator-hugegraph/blob/8abf3d5524de3d3d5a97bbdce460a75652792b0d/hugegraph-dist/src/main/resources/log4j2.xml#L56-L58

Modifications

  • Shutdown log when shutdown process
  • Improve RIGHT_MARGIN and SOFT_MARGINS

@coderzc coderzc added the improvement General improvement label Nov 22, 2022
@coderzc coderzc added this to the 1.0.0 milestone Nov 22, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Merging #2028 (cc00726) into master (aa0d8da) will increase coverage by 3.99%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2028      +/-   ##
============================================
+ Coverage     62.39%   66.38%   +3.99%     
- Complexity      976      978       +2     
============================================
  Files           482      482              
  Lines         41462    41463       +1     
  Branches       5890     5890              
============================================
+ Hits          25869    27524    +1655     
+ Misses        13046    11243    -1803     
- Partials       2547     2696     +149
Impacted Files Coverage Δ
...java/com/baidu/hugegraph/dist/HugeGraphServer.java 35.93% <0.00%> (-0.58%) ⬇️
...va/com/baidu/hugegraph/util/collection/IntSet.java 73.72% <0.00%> (-1.28%) ⬇️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 79.93% <0.00%> (ø)
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 72.22% <0.00%> (+0.30%) ⬆️
...va/com/baidu/hugegraph/util/collection/IntMap.java 72.80% <0.00%> (+0.39%) ⬆️
...gegraph/backend/cache/CachedSchemaTransaction.java 90.82% <0.00%> (+0.48%) ⬆️
...om/baidu/hugegraph/task/StandardTaskScheduler.java 75.56% <0.00%> (+0.49%) ⬆️
.../main/java/com/baidu/hugegraph/util/Consumers.java 56.84% <0.00%> (+0.68%) ⬆️
.../baidu/hugegraph/backend/tx/SchemaTransaction.java 89.61% <0.00%> (+0.69%) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 79.09% <0.00%> (+0.69%) ⬆️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coderzc coderzc requested review from Linary, imbajin and javeme and removed request for Linary and javeme November 22, 2022 05:47
imbajin
imbajin approved these changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@javeme javeme merged commit 4c232a6 into master Nov 22, 2022
@javeme javeme deleted the improve_log_shutdown branch November 22, 2022 12:35
imbajin pushed a commit to z7658329/hugegraph that referenced this pull request Nov 23, 2022
@coderzc @imbajin
Shutdown log when shutdown process (apache#2028)
a443d77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javeme javeme javeme approved these changes

@imbajin imbajin imbajin approved these changes

Assignees

No one assigned

Labels

improvement General improvement

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@coderzc @javeme @imbajin