Conversation
zhoney
reviewed
Aug 21, 2018
Contributor
There was a problem hiding this comment.
combine state checking before open() in initBackend() with this commit
Contributor
There was a problem hiding this comment.
keep 'backend' and 'serializer' original
Contributor
There was a problem hiding this comment.
no need to clear variables?
Contributor
There was a problem hiding this comment.
truncate will delete system pk and vl， is it necessary？
Otherwise， counter will not be cleared
Contributor
Author
There was a problem hiding this comment.
yes it will delete system pk and vl.
counter should also be cleared. maybe some backends are forgotten to clear counter, but now they are all done.
javeme
force-pushed
the
speed-up-tinkerpop-test
branch
3 times, most recently
from
7feedc9 to
2c0736b
Compare
This was referenced Aug 22, 2018
javeme
force-pushed
the
speed-up-tinkerpop-test
branch
from
2c0736b to
72b8fb1
Compare
how to: 1.speed up rocksdb backend by truncating tables 2.don't need to clear if the database is empty 3.don't need to clear variables if it's empty 4.don't need to commit hbase each len-prefix for delete index-label potential problems: 1.mysql may block if create task vertex-label when truncating table 2.rocksdb may miss CF if create task vertex-label when truncating table 3.hbase may block if truncate hbase with version<2.0 improve #14 Change-Id: I4b2393aea8b0fc63c1886e984a576a1f5808b25c
javeme
force-pushed
the
speed-up-tinkerpop-test
branch
from
72b8fb1 to
de16634
Compare
Contributor
Author
|
close since fixed at #208 |
zhoney
pushed a commit
to zhoney/hugegraph
that referenced
this pull request
Nov 9, 2021
…ache#19) Co-authored-by: guoyonggang <[email protected]>
imbajin
pushed a commit
that referenced
this pull request
Oct 19, 2022
imbajin
pushed a commit
that referenced
this pull request
Nov 2, 2022
imbajin
pushed a commit
that referenced
this pull request
Nov 7, 2022
imbajin
pushed a commit
that referenced
this pull request
Nov 9, 2022
imbajin
added a commit
to koi2000/incubator-hugegraph
that referenced
this pull request
Aug 11, 2025
[pull] master from apache:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
how to:
1.speed up rocksdb backend by truncating tables
2.don't need to clear if the database is empty
3.don't need to clear variables if it's empty
4.don't need to commit hbase each len-prefix for delete index-label
potential problems:
1.mysql may block if create task vertex-label when truncating table
2.rocksdb may miss CF if create task vertex-label when truncating table
3.hbase may block if truncate hbase with version<2.0
improve #14
Change-Id: I4b2393aea8b0fc63c1886e984a576a1f5808b25c