fix test-module checkstyle by JackyYangPassion · Pull Request #1842 · apache/hugegraph

JackyYangPassion · 2022-04-23T16:12:09Z

fix hugegraph-test checkstyle issue
TODO: move java class to test/java

hugegraph-test/src/test/java/com/baidu/hugegraph/core/AuthTest.java

javeme · 2022-04-24T03:43:26Z

It seems that renaming to "test" package will trigger running all tests, but we expect all tests to be executed in multiple stages

javeme · 2022-04-26T04:55:42Z

ci error:

Error:  Tests run: 727, Failures: 1, Errors: 0, Skipped: 81, Time elapsed: 229.553 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error:  testGremlinJobAndRestore(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 1.215 s  <<< FAILURE!
java.lang.AssertionError: expected:<CANCELLING> but was:<FAILED>
	at com.baidu.hugegraph.core.TaskCoreTest.testGremlinJobAndRestore(TaskCoreTest.java:629)

hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java

hugegraph-test/src/main/java/com/baidu/hugegraph/core/TaskCoreTest.java

hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java

codecov · 2022-04-26T06:25:37Z

Codecov Report

Merging #1842 (552cbfc) into master (c128b4a) will increase coverage by 4.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1842      +/-   ##
============================================
+ Coverage     66.91%   70.96%   +4.05%     
  Complexity      982      982              
============================================
  Files           447      447              
  Lines         38072    38076       +4     
  Branches       5401     5401              
============================================
+ Hits          25475    27022    +1547     
+ Misses        10082     8408    -1674     
- Partials       2515     2646     +131

Impacted Files	Coverage Δ
.../backend/store/cassandra/CassandraSessionPool.java	`59.00% <0.00%> (-0.60%)`	⬇️
...aidu/hugegraph/backend/store/hbase/HbaseTable.java	`75.92% <0.00%> (ø)`
...idu/hugegraph/backend/store/hbase/HbaseTables.java	`90.00% <0.00%> (ø)`
...ugegraph/backend/store/rocksdb/RocksDBOptions.java	`99.25% <0.00%> (ø)`
...gegraph/backend/store/rocksdb/RocksDBSessions.java	`100.00% <0.00%> (ø)`
...u/hugegraph/backend/store/hbase/HbaseSessions.java	`60.00% <0.00%> (+0.05%)`	⬆️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java	`80.14% <0.00%> (+0.20%)`	⬆️
...aidu/hugegraph/backend/store/hbase/HbaseStore.java	`74.05% <0.00%> (+0.21%)`	⬆️
...c/main/java/com/baidu/hugegraph/task/HugeTask.java	`72.22% <0.00%> (+0.30%)`	⬆️
.../baidu/hugegraph/backend/tx/SchemaTransaction.java	`89.31% <0.00%> (+0.38%)`	⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c128b4a...552cbfc. Read the comment docs.

imbajin · 2022-04-26T09:45:02Z

@seagle-yuan seems it's confuse and break the IDE default wrap behavior with 8 space in new line

consider keep the original style is better (or maybe we need a easy way to keep the wrap unify)

seagle-yuan · 2022-05-03T10:47:32Z

@seagle-yuan seems it's confuse and break the IDE default wrap behavior with 8 space in new line

consider keep the original style is better (or maybe we need a easy way to keep the wrap unify)

need to update checkstyle version
#1857
checkstyle/checkstyle#3342

hugegraph-test/src/main/java/com/baidu/hugegraph/api/MetricsApiTest.java

hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java

JackyYangPassion · 2022-05-06T03:39:35Z

Change the checkstyle version and keep the original style lambda alignment. At present, this module has been reduced from 1500+ to 900+. It is expected to be repaired this week

mvn compile checkstyle:checkstyle

javeme · 2022-05-07T11:49:20Z

please rebase latest master branch

javeme · 2022-05-08T03:44:06Z

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cache/CachedGraphTransactionTest.java

        cache.addVertexProperty(new HugeVertexProperty<>(v1,
-                                                         cache.graph().schema().getPropertyKey("name"),
+                                                         cache.graph().schema()
+                                                              .getPropertyKey("name"),


can align with .graph()

Can you give a code example?

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/SecurityManagerTest.java

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cassandra/CassandraTest.java

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/RolePermissionTest.java

javeme · 2022-05-12T05:57:00Z

seems didn't move java class to test/java

javeme reviewed Apr 24, 2022

View reviewed changes

hugegraph-test/src/test/java/com/baidu/hugegraph/core/AuthTest.java Outdated Show resolved Hide resolved

hugegraph-test/src/test/java/com/baidu/hugegraph/core/AuthTest.java Outdated Show resolved Hide resolved

JackyYangPassion force-pushed the fix-checkstyle-hugegraph-test branch from 8e71489 to 21cc1b6 Compare April 25, 2022 12:08

javeme reviewed Apr 26, 2022

View reviewed changes

javeme previously approved these changes Apr 26, 2022

View reviewed changes

javeme reviewed May 4, 2022

View reviewed changes

hugegraph-test/src/main/java/com/baidu/hugegraph/api/MetricsApiTest.java Outdated Show resolved Hide resolved

hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java Outdated Show resolved Hide resolved

JackyYangPassion added 2 commits May 7, 2022 22:49

fix hugegraph-test checkstyle issue

ad810d3

keep the original style lambda alignment

b95626a

JackyYangPassion dismissed javeme’s stale review via b95626a May 7, 2022 16:31

JackyYangPassion force-pushed the fix-checkstyle-hugegraph-test branch from 5f72ead to b95626a Compare May 7, 2022 16:31

JackyYangPassion added 2 commits May 8, 2022 00:51

keep the original style lambda alignment

5df775e

keep the original style lambda alignment

aa720f9

javeme reviewed May 8, 2022

View reviewed changes

change try catch

d48d893

seagle-yuan suggested changes May 10, 2022

View reviewed changes

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cassandra/CassandraTest.java Show resolved Hide resolved

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/RolePermissionTest.java Show resolved Hide resolved

fix comma line and align with left parenthesis

552cbfc

javeme approved these changes May 11, 2022

View reviewed changes

seagle-yuan approved these changes May 11, 2022

View reviewed changes

JackyYangPassion marked this pull request as draft May 11, 2022 05:41

JackyYangPassion marked this pull request as ready for review May 11, 2022 05:43

imbajin approved these changes May 12, 2022

View reviewed changes

imbajin merged commit 2d25938 into apache:master May 12, 2022

imbajin changed the title ~~fix hugegraph-test checkstyle issue and move java class to test/java~~ refact: move java class to test/java & fix test code check-style May 12, 2022

javeme changed the title ~~refact: move java class to test/java & fix test code check-style~~ fix test-module checkstyle May 12, 2022

Conversation

JackyYangPassion commented Apr 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javeme commented Apr 24, 2022

Uh oh!

javeme commented Apr 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

imbajin commented Apr 26, 2022

Uh oh!

seagle-yuan commented May 3, 2022

Uh oh!

Uh oh!

Uh oh!

JackyYangPassion commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javeme commented May 7, 2022

Uh oh!

javeme May 8, 2022

Choose a reason for hiding this comment

Uh oh!

JackyYangPassion May 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javeme commented May 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JackyYangPassion commented Apr 23, 2022 •

edited

Loading

codecov bot commented Apr 26, 2022 •

edited

Loading

JackyYangPassion commented May 6, 2022 •

edited

Loading